Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TileLoading / TileMesh-Generation causing visual glitches --> non necassary empty tiles #1849

Open
Markovicho opened this issue Feb 3, 2022 · 7 comments

Comments

@Markovicho
Copy link

We using the latest commit from performance branch:

Basic 2D Map is working really well and i see no bugs in terms of a critical issues or crashes at all. Nice work so far and we are pretty much looking forward to the refactored version of AbstractMap and VectorFeatures.

@brnkhy
But we experience visual glitchtes while lerping between zoom-levels. Especially in some cases where the ZoomLevel changes to the next whole number (11.01 --> 10.99) seems to trigger the glitch based on the regeneration of the tilemesh-layout combined with tile-texture loading. Whats happening in the below video for a few milliseconds can be extrapolated to multiple seconds for RangeAroundCenter with large extents. By the way it does not matter which kind of TileProvider you're using (CameraBounds, RangeAroundCenter etc)

If it would be helpful to reproduce the issue i could create a little sampleproject including an animated zoomlevel-change which is causing the issue constistently. @brnkhy would that be helpful or is the issue easy to reproduce ? :-)

MapBox_TileMesh_Creation_Issue_case1.mp4
@brnkhy
Copy link
Contributor

brnkhy commented Feb 7, 2022

@Markovicho this is the torturous issue I have been struggling for months (in different branches/applications/ways etc). I can't remember latest on performance branch but I thought it was fixed there. I'll try to look into that soon.
but tile management seems wrong in the code you are using. when that white background happens, you can see there are no tiles in the scene view. latest solution actually didn't dispose tiles until new ones are properly loaded 🤔

@brnkhy
Copy link
Contributor

brnkhy commented Feb 8, 2022

I checked this quickly today turns out it's not the default behavior and branch normally acts as I thought it should (tiles filling in for each other etc). so this should be a bug, probably due to some sort of different settings (or a cache related issue).
can you verify that @Markovicho ? does this disappearing tiles thing happens on test/demo scene by default for example?

@Markovicho
Copy link
Author

Hey @brnkhy

thx for taking your time so quickly regarding this issue. I will check out performance branch in a separate project and try to reproduce it.

@Markovicho
Copy link
Author

Markovicho commented Feb 8, 2022

bad news @brnkhy

  • used Unity 2021.2.10 (on 2020 it's the same...)
  • created new unity project
  • checked out your latest commit on performance branch
  • no changes made at all
  • imported mapbox sdk folder and set up mapbox access token
  • Opened Zoomable Map Scene
  • cleared file cache
  • build target : Windows (doesn't matter)

Result:

It seems to work well for the first time i move up to zoomlevel 2.
Moving back to 16 it seems to happen for every full integer zoom value oO (f.e happening around 0:20min)
I saw you changed the exception print-out in CachingWebFileSource.cs. But the console looks still fine.

2022-02-08.17-52-37.mp4

switched to Android and this what it looks like on phone:

screen-20220208-181340.mp4

@Markovicho
Copy link
Author

@brnkhy any news on this one ?

@neoneper
Copy link

neoneper commented May 1, 2022

Hello: any resolution to this problem?

@brnkhy
Copy link
Contributor

brnkhy commented May 17, 2022

@Markovicho @neoneper I haven't had a chance to look into it for that exact commit (branch) but I think it's working much better now.
https://twitter.com/brnkhy/status/1518894938351669248
I'll try to share it with you all as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants