Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

IE9 jsonp (?) issues #134

Closed
lxbarth opened this Issue · 22 comments

8 participants

@lxbarth
Admin

I'm observing 2 likely related issues w/ mapbox.js HEAD and IE9 (9.0.8112):

  1. mapbox.load() sporadically returning an empty tilejson object
  2. interactivity dead where MapBox hosting returns 304 (not modified)

Example

I cannot reproduce these issues with an older setup, e. g.:

http://www.npr.org/censusmap/#6.00/41.152/-90.943

@tmcw tmcw was assigned
@lxbarth
Admin

Possibly related #127

@gundersen
Admin

@tmcw how much of our subscribers are effected by this? How long will it take to fix?

@lxbarth how urgent is this for NYC?

cc @willwhite

@tmcw
Admin

I've filed a ticket for the upstream problem & re-noted it. I can't really guess how many people are affected by this, since the issues are new to me, haven't been reported in support.mapbox.com, and haven't been reported in mapbox or wax till today.

@tmcw
Admin

Does this occur in IE<9?

@dhcole

@tmcw I saw it in IE8 too, and more often.

@tmcw
Admin

@dhcole I thought your problem was related to map loading only? Did you see the other two issues alex is talking about here?

@dhcole

Yes I was specifically seeing 1) with mapbox.load and mapbox.auto.

@lxbarth
Admin

The interactivity bug described also affects MapBox hosting: http://tiles.mapbox.com/villeda/map/nyc-sandy

@willwhite
Admin

MapBox supports standard JSONP now. The task is now to add support to mapbox.js and do a release.

@lxbarth
Admin

HOTDOG!

@tmcw
Admin

Will be able to tackle this early next week.

@gundersen
Admin

@tmcw how big of a lift is this and can @ansis help?

@ansis
Admin

@tmcw, what is it that needs to be done?
I haven't been able to reproduce either of the issues in an IE8 vm.

@tmcw
Admin

Basically:

  • We need to re-test reqwest in IE8, 9, and 10. The problems got worse in 10, with people reporting that it's entirely broken (including shawn at stamen). Either fix or switch there.
  • Test mapbox.js in IE9, test multiple maps on the same page, and interaction - and change the hardcoded grid callback in wax.request.get to use unique callbacks for safety.
@willwhite
Admin

@ansis what is your week looking like? Is this something you could look at?

@tmcw
Admin

@ansis any luck on this? Is anyone else in a position to take this work? It'd likely be better for me to keep on iD + Leaflet investigation rather than get pulled off onto this potentially long task.

@tmcw
Admin

@yhahn do you have time to take a look at this one? reqwest hasn't been updated in 6 months, which isn't good, but there also are no clear alternatives I'm seeing other than superagent. just using multiple callback names may fix the problem, though not sure.

@yhahn
Admin

Where we're at:

Updated to point at jsonpcallback branches of wax and markers.js that continue to use reqwest but with its built-in dynamic callback support. I've added a testcase/jsonp.html in both master and jsonpcallback.

The problems we're running into at this point are:

  • Both master and jsonpcallback branches work on IE8 and IE9 with the testcase so it's not clear whether the changes actually fix anything.
  • Interaction continues to be broken in IE10.

The next task on hand is to come up with a test case that is reliably broken in IE9.

@willwhite
Admin

Assigned to Tender discussion #635.

@willwhite
Admin

Partly addressing with ded/reqwest#89

@yhahn
Admin

This should be resolved with #139. I've rolled a 0.6.7-dev with this fix and packaged it up here:

Would love confirmation of the fix so we can roll a 0.6.7.

@mnoble01

Awesome, fixed the map loading issue for me in IE9. Great work!

@yhahn yhahn closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.