Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Japan realignment and add roads #116

Closed
samely opened this issue Sep 1, 2015 · 16 comments
Closed

Japan realignment and add roads #116

samely opened this issue Sep 1, 2015 · 16 comments

Comments

@samely
Copy link

samely commented Sep 1, 2015

Task http://tasks.openstreetmap.in/project/31#

Realign and add new residential and main roads.

Task coverage

  • Chiba Prefecture, Japan

Tracing Sources

  • Japan GSI Orthorectified Satellite: http://cyberjapandata.gsi.go.jp/xyz/ort/{z}/{x}/{y}.jpg
  • Bing (offset)
  • Mapbox Satellite (offset)

Reference Sources

  • Strava Globalheat: http://globalheat.strava.com/tiles/both/color3/{zoom}/{x}/{y}.png
  • OSM GPS : http://{switch:a,b,c}.gps-tile.openstreetmap.org/lines/{z}/{x}/{y}.png
  • Japan GSI Map 2012 http://cyberjapandata.gsi.go.jp/xyz/std2012/{z}/{x}/{y}.png

Timeline

  • @mapbox/team-data will work since Tuesday 1st of September at 13:30 hours. Team training was done and expected completion is about a week.
  • team-blr are on the task full time from 09/04

Instructions

  • Align and add roads verifiable from satellite imagery
  • If editing in a actively mapped area, add a note instead of making a fix. Don't assume anything.
  • If using Japan Layer to add or align, tag the road with source=GSImaps/TileID.

Tips and tricks

  • Lower the opacity of the Japan Layer to 30% or 20% to align with Bing and GPS layers.
  • You can select a road and align it with Improve way accuracy mode (w). Also you can add nodes with Ctrl.
    image
  • You can add filters boundary: | leisure: | landuse: | waterway: | sport: |amenity: | natural:|building: | admin_level: | power: | place: | type:relation | electrified :| railway:| aeroway:

cc. @mapbox/team-data @lxbarth @aaronlidman

@pratikyadav
Copy link
Contributor

As per voice with @planemad , the Japan Layer seems to be accurate for major roads but not for minor roads. Thus, for minor roads the primary source of mapping should be Bing/Mapbox-satellite.

japan

@planemad
Copy link
Contributor

planemad commented Sep 3, 2015

@Rub21 we are noticing the above inconsistency in road quality in the Japan layer for minor roads. The problem is not a simple offset, but it does not match the road geometry. There is not much use tracing unclassified or residential roads from it as they will need to be realigned again.

Can you look carefully into this problem and see what is the best way to proceed? Maybe we should only realign roads from tertiary and up in the first pass using the Japan layer.

Only the Strava layers seem accurate to trust but coverage is not good for minor roads.

cc @lxbarth

@almccon
Copy link

almccon commented Sep 3, 2015

It looks like your tasks.openstreetmap.in tasking server has the wrong hashtag assigned to these changesets. It's applying #hotosm-project-31 to the changesets, for example this one: https://www.openstreetmap.org/changeset/33760039

This is not a HOT project, correct? It's project 31 on tasks.openstreetmap.in, but not on http://tasks.hotosm.org/. So the default hashtag needs to be changed.

Thanks for your work! Can I ask what is the context for this Japan mapping task? I'm working on an OSM style for Japan for another project, so I'm curious!

@aaronlidman
Copy link

Hey @almccon, thanks for the heads up. @ediyes fixed the changeset comments.

For context, we've had our eye on fixing Japan for a while. We did a trial run of fixing the well known connectivity issues last November when the team was much smaller and decided to punt for the time being. Before getting to the connectivity issues again we're taking a first pass at alignment issues, which surprised us. Afterwards we'll focus on connectivity, using debugging tools from OSRM to tell us where to fix.

02a30fca-7007-11e4-8dff-dd8a4528cad5 1
Connectivity issues in Tokyo a team of four fixed from Nov 14th - 18th

@almccon
Copy link

almccon commented Sep 3, 2015

Great news! Thanks for the improvement!

@aarthykc
Copy link

aarthykc commented Sep 4, 2015

This could be a possible workflow to realign existing roads or trace new roads:

  • Using the Strava layer align the satellite imagery by using the Imagery Offset setting in Imagery, like this:

offset setting
Now that you've done that you can be sure of the fact that your imagery is correct.

  • After this you can proceed to trace new roads with respect to the imagery. Try as much as possible to NOT use the Japan Layer as a reference as in many places it's incorrect. Like here:
    screen shot 2015-09-04 at 11 53 30 am
  • The imagery offset shifts when you download a new area, so make sure you realign the satellite imagery if required.

@aarthykc
Copy link

aarthykc commented Sep 4, 2015

Case where the road needs to be realigned:
screen shot 2015-09-04 at 2 31 22 pm

@planemad
Copy link
Contributor

planemad commented Sep 4, 2015

Building on @pratikyadav's and @aarthykc's observations, it does not look worthwhile to use the Japan GSI layer directly for tracing new roads as it creates more misaligned data. We need to get our sources in order before tracing.

Step 1: Align the satellite imagery

  • Use the Strava Globalheat layer as the gps reference, if data is not available try using OSM GPS. This is the only dependable reference data collected from the ground.
  • Create a new offset for the Bing or Mapbox Satellite imagery and align it to match the gps reference. This is best done at a road junction where the offset can be corrected on both axis.
  • Verify the offset is accurate by checking the gps layer and satellite imagery at other junctions in the mapping area
    untitled

Step 2: Align the Japan GSI layer

  • Use the same technique to offset the GSI layer to match the major highways with the gps layer.
  • The GSI layer has both offset and geometry distortion from the reality and will not align perfectly with either the data, satellite or gps layer. Minor roads are more distorted and have lower accuracy than highways.
    untitled

Step 3: Realign existing highways and add new roads

  • The priority for sources are: gps layer > satellite imagery > Japan GSI layer

@Andygol
Copy link
Contributor

Andygol commented Sep 4, 2015

http://wiki.openstreetmap.org/wiki/Imagery_Offset_Database/Quick_Start

@planemad
Copy link
Contributor

planemad commented Sep 4, 2015

Comparison of GPS corrected OSM data vs Japan GSI layer:

  • For this small town the difference was in the range of 4-16m
    screen shot 2015-09-04 at 4 26 42 pm

@planemad
Copy link
Contributor

planemad commented Sep 4, 2015

@Andygol Amazing find. The GSI orthorectified imagery matches the GPS data perfectly. It is the GSI maps that are inaccurate.
screen shot 2015-09-04 at 4 33 57 pm

Going to update the instructions.

@planemad planemad mentioned this issue Sep 14, 2015
3 tasks
@mapconcierge
Copy link

Hi, all:

About Reference data,
We should use below GSImaps layers

std(maximum zoom level: 18)
http://cyberjapandata.gsi.go.jp/xyz/std/{z}/{x}/{y}.png

ort(maximum zoom level: 18)
http://cyberjapandata.gsi.go.jp/xyz/ort/{z}/{x}/{y}.png

Both ort and std should not have offset, as you know wink emoticon

@planemad
Copy link
Contributor

@mapconcierge

From trials, the ort imagery is very good and matches the Strava GPS traces. But the coverage of the imagery over Japan is not complete.

The std maps are accurate for major highways (motorway - secondary) but are not reliable for smaller roads and rural areas where the accuracy is poor.

Positional accuracy of data

  1. Strava Globalheat
  2. GSI Japan Satellite (ort)
  3. GSI Japan Map (std) [Only major highways and cities]
  4. OSM GPS
  5. Bing Satellite
  6. OSM Data

@mapconcierge
Copy link

Okay, I agree your priorities.

@mapconcierge
Copy link

We made a task for Aomori area on TeachOSM.
http://tasks.openstreetmap.in/project/40

@planemad
Copy link
Contributor

Tracking on #120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants