Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To-fix: Broken polygons #206

Closed
samely opened this issue Jun 30, 2016 · 24 comments
Closed

To-fix: Broken polygons #206

samely opened this issue Jun 30, 2016 · 24 comments
Labels

Comments

@samely
Copy link

samely commented Jun 30, 2016

Objective

Close polygons which are broken.

Tasks

The task below is updating everyday from Monday to Friday with the latest errors in OpenStreetMap

Changeset comment

Fixing invalid multipolygon relation by closing unclosed rings and self intersecting areas using #to-fix https://github.com/mapbox/mapping/issues/206

Coverage

All countries in this list: https://s3.amazonaws.com/mapbox/to-fix/mbtiles.txt

Tools

  • If using iD editor, work with To-Fix web
  • If using JOSM, work with Josm-tofix-plugin
  • Use split way tool (Shortcut: P)
  • Use unglue tool (Shortcut: G)

Instructions

  • If the highway has any tag for areas (i.e. landuse or buildings) delete this tag.
  • If the area has a self-intersect node, disengage it and reshape the area.
  • If editing in an actively mapped area, add a note instead of making a fix.
  • If satellite imagery isn't clear click on not an error of to-fix
  • Check in osm layer if the polygon dos not show. example

Common issues

image
Delete the building=yes tag

image
Delete the irrelevant node

image

How are we doing the error detection?

We are using osm-qa-tiles and osmlint selfIntersectingHighways

Who will work on these tasks?

Everybody is available to work on resolving these issues. However, @mapbox/data-team (Peru office) will work on everyday.

Question

Tag @planemad or @Rub21 for questions.

cc. @mapbox/team-data

@samely samely added the task label Jun 30, 2016
@dannykath
Copy link

Broken polygons issues from 07/11/2016 - 07/14/2016
Date N° detected error Total Fixed
Wednesday 13th, July 65652 1600
Thursday 14th, July 49930 1526
Total -- 3126

@luiswalter
Copy link

Broken polygons issues from 07/18/2016 - 07/22/2016
Date N° detected error Total Fixed
Monday 18th, July 44,430 1,992
Wednesday 20th, July 39,380 2,574
Thursday 21th, July 38,709 671
Total -- 5,237

@calfarome
Copy link

Broken polygons issues from 07/25/2016 - 07/27/2016
Date N° detected error Total Fixed
Monday 25th, July 18772 189
Wednesday 26th, July 17878 0
Thursday 27th, July 17891 0
Total -- 189

@1ec5
Copy link

1ec5 commented Sep 23, 2016

This changeset claims to be fixing a multipolygon, but it doesn’t look like the edited way was ever part of a multipolygon. Instead, it removed golf and natural tags added as part of iD’s Lateral Water Hazard preset. Was this intentional, and if so, should iD’s preset be corrected? According to the wiki, golf=lateral_water_hazard is legitimate, although natural=water might be inappropriate for a way.

/cc @bhousel

@bhousel
Copy link

bhousel commented Oct 7, 2016

Thanks for catching this @1ec5.. Indeed iD was adding broken natural=water polygons via the water hazard presets. I just fixed this! 🏌️

re openstreetmap/iD#3483

@amandasaurus
Copy link

Hi! I think there might be a bug with your workflow/scripts/detection/etc. In changeset 44,381,869 mapper piligab broke a previously valid relation (relation 4,590,559 - Ballybetagh) with the changeset comment of "Fixing broken relation"

@bsrinivasa
Copy link

@rory Thank you for identifying this. This could have possibly happened due to flagging of the relation under ring not closed in To-Fix Task. Usually, in the cases similar to the above, the missing way segment is added into the relation but wherein in this changeset 44,381,869, the way segment 326233195 was deleted from the relation. @piligab It would be great if you can check the relation in To-Fix task and clarify why the member was removed from the relation.
cc: @geohacker @Rub21 @poornibadrinath

@piligab
Copy link

piligab commented Dec 15, 2016

Hi @rory!
I'm not sure how this happened, maybe I could have confused any tags and deleted. I will be careful about my future editions. Thanks for your feedback.

cc. @bsrinivasa, @poornibadrinath, @Rub21, @geohacker

@luiswalter
Copy link

Broken polygons issues from 01/16/2017 - 01/20/2017
Date N° detected error Total Fixed
Tuesday 17th, January 121 18
Thursday 26th, January 31 1
Total -- 19

@karitotp
Copy link

Broken polygons Progress issues from 01/23/2017 - 01/27/2017
Date N° detected error Total Fixed
Monday 23rd January 58 24
Wednesday 25th January 52 41
Thursday 26th January 13 7
Friday 27th January 36 23
Total -- 95

@ediyes ediyes closed this as completed Jan 27, 2017
@ediyes ediyes reopened this Jan 27, 2017
@karitotp
Copy link

karitotp commented Feb 3, 2017

Broken polygons Progress issues from 01/30/2017 - 02/03/2017
Date N° detected error Total Fixed
Tuesday 31st January 73 54
Thursday 02nd Febrary 51 39
Total -- 93

@karitotp
Copy link

Broken polygons Progress issues from 02/06/2017 - 02/10/2017
Date N° detected error Total Fixed
Monday 06th Febrary 46 3
Total -- 3

@karitotp
Copy link

Broken polygons Progress issues from 02/13/2017 - 02/17/2017
Date N° detected error Total Fixed
Thursday 16th February 229 80
Friday 17th February 128 84
Total -- 164

@karitotp
Copy link

Broken polygons Progress issues from 02/20/2017 - 02/24/2017
Date N° detected error Total Fixed
Monday 20th February 53 17
Tuesday 21st February 25 7
Wednesday 22nd February 18 5
Total -- 29

@karitotp
Copy link

karitotp commented Mar 6, 2017

Broken polygons Progress issues from 02/27/2017 - 03/03/2017
Date N° detected error Total Fixed
Tuesday 28th February 131 49
Wednesday 01st March 74 20
Thursday 02nd March 87 38
Total -- 107

@karitotp
Copy link

Broken polygons Progress issues from 03/06/2017 - 03/10/2017
Date N° detected error Total Fixed
Monday 06th March 84 42
Tuesday 07th March 24 12
Wednesday 08th March 12 2
Friday 10th March 69 43
Total -- 99

@karitotp
Copy link

Broken polygons Progress issues from 03/13/2017 - 03/17/2017
Date N° detected error Total Fixed
Wednesday 15th March 133 17
Friday 17th March 134 63
Total -- 80

@karitotp
Copy link

Broken polygons Progress issues from 03/20/2017 - 03/24/2017
Date N° detected error Total Fixed
Monday 20th March 58 30
Wednesday 22nd March 22 7
Thursday 23rd March 48 3
Total -- 40

@karitotp
Copy link

Broken polygons Progress issues from 04/03/2017 - 04/07/2017
Date N° detected error Total Fixed
Wednesday 05th April 80 45
Thursday 06th April 7 5
Total -- 50

@karitotp
Copy link

Broken polygons Progress issues from 04/10/2017 - 04/14/2017
Date N° detected error Total Fixed
Monday 10th April 365 67
Tuesday 11th April 224 42
Wednesday 12th April 182 102
Total -- 211

@karitotp
Copy link

Broken polygons Progress issues from 04/17/2017 - 04/21/2017
Date N° detected error Total Fixed
Tuesday 18th April 21 14
Wednesday 19th April 3 1
Total -- 15

@karitotp
Copy link

karitotp commented May 2, 2017

Broken polygons Progress issues from 04/24/2017 - 04/28/2017
Date N° detected error Total Fixed
Thursday 27th April 247 43
Total -- 43

@karitotp
Copy link

karitotp commented May 5, 2017

Broken polygons Progress issues from 05/01/2017 - 05/05/2017
Date N° detected error Total Fixed
Tuesday 02nd 247 35
Wednesday 03rd May 47 27
Thursday 04th May 30 9
Friday 05th May 3 2
Total -- 73

@karitotp
Copy link

Broken polygons Progress issues from 05/08/2017 - 05/12/2017
Date N° detected error Total Fixed
Monday 08th, May 26 7
Tuesday 09th, May 4 4
Wednesday 10th, May 3 1
Friday 12th, May 31
Total -- 43

@maning maning closed this as completed Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests