Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Should mb-util create JSON files for tiles that don't exist? #32

Open
Schwanksta opened this Issue · 5 comments

3 participants

@Schwanksta

Right now, mb-util creates many more JSON files than tiles. We could move the grid output code up to the tile output code so we only output a grid file if there is a tile. Does that sound like something worth a patch?

@tmcw
Owner

Yeah, makes sense, can you write this?

@Schwanksta

Shouldn't be too complicated. I'll play with it later.

@mikejcorey

Would love to see this happen -- well over half my export/upload time is blank grids a lot of the time.

@tmcw
Owner

PRs accepted here - this is a fairly simple library and easy to change.

@mikejcorey

I sent in a pull request, but it's failing a test. I think the test might now be invalid, however: It's looking for a grid that may not exist, depending on the data set.:

assert os.path.exists('test/output/imported/0/0/0.grid.json')

https://travis-ci.org/mapbox/mbutil/jobs/33538870

Of course I could also be reading that wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.