-
Notifications
You must be signed in to change notification settings - Fork 5
Style helper tool #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
zmofei
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let some comments.
I think in the current case, we are too detailed, we can't possibly list all the layers and categories, I suggest it's better to let the LLM know how to set up the layers, how to configure the colors and other general information through this TOOL.
Please refer to streets v8 tileset specification https://docs.mapbox.com/data/tilesets/reference/mapbox-streets-v8/#landuse for all the details layers and properties.
Also, we could think about the standard style(not only the classical style) as well.
|
|
||
| export const StyleHelperToolSchema = z.object({ | ||
| step: z | ||
| .enum(['start', 'features', 'colors', 'generate']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there an introduction about how and when to use those steps? Can LLM understand this?
| show_pois: z.boolean().optional().describe('Show POI labels'), | ||
| show_road_labels: z.boolean().optional().describe('Show road labels'), | ||
| show_place_labels: z.boolean().optional().describe('Show city/town labels'), | ||
| show_transit: z.boolean().optional().describe('Show transit features'), | ||
| show_buildings: z.boolean().optional().describe('Show buildings'), | ||
| show_parks: z.boolean().optional().describe('Show parks and green spaces'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We seems trying to list the layers, but can we exhaust all the layers?
For example: in streets v8 tileset we have airport_label , landuse_overlay, natural_label etc. are this listed here? Maybe it's better to "teach" LLM how to do the general configure and provide the resources(i.e. all the layers from streets v8), so that agent can do the job by themself, not relay on we list the possible features layers here.
| road_color: z.string().optional().describe('Road color (hex)'), | ||
| water_color: z.string().optional().describe('Water color (hex)'), | ||
| building_color: z.string().optional().describe('Building color (hex)'), | ||
| land_color: z.string().optional().describe('Land/background color (hex)'), | ||
| park_color: z.string().optional().describe('Park color (hex)'), | ||
| label_color: z.string().optional().describe('Label text color (hex)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The same here, the source layer could be a lot, how could we involved all related layers?
For example:
- In the
water_colorwe only control thewaterlayer, but how about thewaterwaylayer?
The - In the
land_colorwe control all the features fromlanduselayer, but how aboutlanduse_overlaylayer? And if we listed thepark_color, how aboutairport_color,grass_color,sand_coloretc.?
Description
Introduces a new interactive tool that guides users through creating custom Mapbox styles step-by-step.
How It Works
The tool follows a 4-step wizard flow:
Key Features
Output
Generates a complete Mapbox style JSON that includes:
Testing
Checklist
Additional Notes