Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uppre-gyp looks for the wrong ABI in electron childProcess.forks #278
Comments
bcomnes
changed the title from
pre-gyp looks for the wrong ABI in electron childProcess.fork's
to
pre-gyp looks for the wrong ABI in electron childProcess.forks
Mar 28, 2017
This was referenced Mar 28, 2017
added a commit
to bcomnes/node-pre-gyp
that referenced
this issue
Mar 29, 2017
bcomnes
referenced this issue
Mar 29, 2017
Open
Allow electron process forks of modules that use pre-gyp #279
added a commit
to bcomnes/node-pre-gyp
that referenced
this issue
Apr 12, 2017
added a commit
to bcomnes/node-pre-gyp
that referenced
this issue
May 4, 2017
added a commit
to bcomnes/node-pre-gyp
that referenced
this issue
May 5, 2017
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Tomyail
commented
Jan 12, 2018
|
any update for this issue? I need this pull request |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
Tomyail
commented
Jan 12, 2018
|
I create a pull request for this issue |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
bcomnes
Sep 11, 2018
This is my original PR to close this: #279
Open to either solution, but I think we should aim to make this work without user provided env vars.
bcomnes
commented
Sep 11, 2018
|
This is my original PR to close this: #279 Open to either solution, but I think we should aim to make this work without user provided env vars. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bcomnes commentedMar 28, 2017
•
edited
It appears node-pre-gyp modules are trying to use the wrong ABI when run inside of a childProcess.fork from an electron process, even if you have rebuilt the correct ABI using something like electron-rebuild. It looks like this problem has been around a while, and even a few hacks came and went.
Here is an example of the issue with sqlite3: https://github.com/ballpit/electron-sqlite3-fork-bug/blob/master/main.js
It looks like node-gyp-build had a similar issue a while back, and they ended up implementing a check for the process.env.ELECTRON_RUN_AS_NODE and returning electron bindings when thats found, and it looks like maybe we need to port that over to node-pre-gyp as well to fix this problem.
It looks like the ABI selection is happening in https://github.com/mapbox/node-pre-gyp/blob/master/lib/util/versioning.js. Any idea where such a check might live in that file?