New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support Atom Shell as a runtime #112

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
9 participants
@Mithgol
Contributor

Mithgol commented Sep 18, 2014

The following additions have to be implemented to support Atom Shell and fix #110:

  • add atom-shell-related versioning
  • add atom-shell-related building of native modules
  • add atom-shell-relating testing of builds
  • add atom-shell-related docs (mostly in README)

Note: this pull request also fixes #111 because is based on its branch.

@springmeyer

This comment has been minimized.

Member

springmeyer commented Sep 19, 2014

Does atom-shell support process.versions.modules? I'm not sure I want to support atom-shell without it. The burden of the non-compatibility-promise across patch level node-webkit versions is not ideal and I'd prefer to avoid it with atom-shell.

@springmeyer

This comment has been minimized.

Member

springmeyer commented Sep 19, 2014

Looks like process.versions.modules is 14 for the latest release of atom-shell (v0.16.2) so at least it gets reported. I wonder if it is meaningful.

@springmeyer

This comment has been minimized.

Member

springmeyer commented Sep 19, 2014

I wonder if it is meaningful.

I've ask in electron/electron#533 (comment)

@springmeyer

This comment has been minimized.

Member

springmeyer commented Sep 21, 2014

sounds like we are good to go using process.versions.modules with atom-shell as @zcbenz has confirmed he will plan to bump it independently in atom-shell when he breaks ABI (via a v8 upgrade or some other major change): electron/electron#533 (comment)

@Mithgol

This comment has been minimized.

Contributor

Mithgol commented Sep 22, 2014

Good.

@camsoupa

This comment has been minimized.

camsoupa commented Sep 27, 2014

When will this be merged in?

@Mithgol

This comment has been minimized.

Contributor

Mithgol commented Sep 27, 2014

Hard to tell; it's ≈25% complete (one checkbox out of four in my TODO list).

@kevinsawicki

This comment has been minimized.

kevinsawicki commented Nov 16, 2014

Just wanted to check in and see if there were any updates on this or if any changes were needed in Atom Shell to support this?

@springmeyer

This comment has been minimized.

Member

springmeyer commented Jan 18, 2015

@kevinsawicki - yes, one more thing is needed to get this off the ground: electron/electron#1022

@johnhaley81

This comment has been minimized.

johnhaley81 commented Mar 15, 2015

electron/electron#1022 got merged in. Is there anything that I could do to help this along? This would really help the user experience with installing nodegit.

@matthewbauer

This comment has been minimized.

matthewbauer commented May 5, 2015

So, this is a little bit off topic, but are there any mechanisms in place to specify that I need a dependency for use with electron/node-webkit? That is, I need node-sqlite3 but even though I'm running node, eventually it will be launched with node-webkit. Right now, I have to manually install node-sqlite3 with node-webkit options after each nom install.

@Mithgol

This comment has been minimized.

Contributor

Mithgol commented May 6, 2015

@matthewbauer I don't know of any such mechanisms but the idea looks interesting.

By the way, what's your best idea of how node-pre-gyp might detect that the package is going to be used in nw.js? It would be easy to detect the nw package among the parent dependencies, for example, but not everyone uses that package.

@springmeyer

This comment has been minimized.

Member

springmeyer commented Jun 25, 2015

@voodootikigod - thanks for the writeup at node-serialport/node-serialport#538. Have been on other projects and had not realized how much of a pain point this missing support has become. Will plan to dig into this next week and get initial "formal" electron support going asap. After I've assessed what remains to be done I'll put a call out for help testing.

@olimsaidov

This comment has been minimized.

olimsaidov commented Jul 10, 2015

Is there any updates?

@johnhaley81 johnhaley81 referenced this pull request Aug 6, 2015

Closed

Installing for Electron #662

@leipert

This comment has been minimized.

leipert commented Aug 28, 2015

Is there any way supporting you with this PR?

@etiktin

This comment has been minimized.

Contributor

etiktin commented Sep 24, 2015

FYI, PR #175 adds basic support for Electron, so you can at least build the project locally.

@springmeyer

This comment has been minimized.

Member

springmeyer commented Oct 5, 2015

Solved by #175 which has been merged and is included in the v0.6.12 release of node-pre-gyp.

@springmeyer springmeyer closed this Oct 5, 2015

@Mithgol Mithgol deleted the Mithgol:support-atom-shell branch Oct 6, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment