Add support for Node 13

[Pomax]

It looks like Sqlite3 is not compatible with Node 13 yet, only Node 12. Can binaries be generated for the new (well... October, but still) major version of Node?

[Pomax]

@kewde any news on this front? Node 13's been out long enough to have had five minor version updates already, and sqlite3 is a common enough library that compatibility with new versions of Node is pretty essential. Especially since it's typically used as the "local dev" equivalent of a full blown database, with local dev generally using the most recent version of Node, rather than the LTS version.

[ibrahimcaj]

Yeah, @kewde any news? It has been over a month since Node 13 release.

[bedwardly-down]

What exactly is the incompatibility here? I'm on Artix Linux running nodejs 13.7.0 with no issues so far. Of course, I'm not directly messing with Sqlite3 but one of the apps I'm contributing to and using uses it pretty heavily for its backend. Thanks

[dhkatz]

The issue is, at least on Windows, is that node-gyp tries to request a pre-built binary for Node 13 (node-v79 ABI) but there isn't any.

It then tries to fall back to building from source, but I doubt most people have a VS 2015 compiler still running.

[bedwardly-down]

Thanks for getting back to me. So it seems to be a Windows only issue that Linux bypasses for the most part, right?

[Pomax]

Any system that knows how to build C++ code using Python via node-gyp for node.js will compile from source, but sqlite3's power is that it doesn't need a build system because all the binaries are prepackaged. It was one of the first projects to add that and it was a god send. Sure, nearly every windows user is affected, but also every lean unix/linux deploy system that only installs exactly what's necessary, and not all headers and libraries necessary to compile things from source. Or even setups that are dedicated node targets and so don't have python installed. Or setups that have python installed but not the now literally dead version of python that node-gyp still rather ridiculously relies on.

So the issue is really just what's listed in the top comment: sqlite3's missing precompiled binaires, can those please be added for all the standard targets, in the same way that's been done since before I last filed an issue about the precompiled binaries back in late 2013.

[kewde]

Support for Node 13 was added in 4.1.1.
I will verify that the windows prebuilt binaries are available.

[kewde]

Seems alright?

https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.1.1/node-v79-win32-x64.tar.gz
https://mapbox-node-binary.s3.amazonaws.com/sqlite3/v4.1.1/node-v79-win32-ia32.tar.gz

Make sure to be on 4.1.1 and re-install node-sqlite3 with node set to v13.