New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark tests that call GDAL binaries (#1555) #1557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Year specified in version 1.0.9 date is 2019, which is in the future at this time. Set to 2018, which is in the past.
(rasterio#1541) * updated _handle_crswkt to use CRS.from_wkt; resolved issue rasterio#1540 * added test for datasetreader opening dataset with ESRI projection wkt string
* Fix a typo (probably) * Update url for manylinux * Update README.rst Co-Authored-By: ismailsunni <imajimatika@gmail.com> * Update README.rst Co-Authored-By: ismailsunni <imajimatika@gmail.com> * Remove unused string
* modified _osr_from_crs to use CRS.from_user_input * update to use tmpdir fixture for pytest * update comparison for error output for rio warp * updated to always attempt to MorphFromESRI to prevent exception from being raised * added test to test warping with ESRI wkt * updated data_dir to be used as fixture * removed duplicate import of CRSError * reordered initialization of spatial reference to prevent memory leaks * updated to raise CRSError of auth != EPSG
)" (rasterio#1548) This reverts commit b120a00.
sgillies
approved these changes
Nov 21, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rmsare thank you!
I've retargeted this at maint-1.0 since we need it to solve the GDAL and PROJ data issues in 1.0.x wheels. |
Great, thanks! Oops, sorry to fork master without looking at your dev branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add markers to tests that call
gdalinfo
.pytest
runs the correct tests using-m "not gdalbin"
and-m "gdalbin"
with test behavior unchanged.This addresses #1555.