Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Interactivity: location seems to be broken #1502

Closed
lxbarth opened this Issue · 11 comments

5 participants

@lxbarth
Admin

Tried to use location interactivity on 0.9.1, unexpectedly, click on an interactive element fails silently.

@tmcw
Admin

Added in Wax 6.2.0, needs integration with TileMill

@ansis
Admin

Whats the correct behavior in TileMill? Opening a browser window? Or do nothing and just export correctly?

@ansis
Admin

Any suggestions for opening a link in an external browser on all platforms (since it can't open in the TileMill standalone browser)?

@tmcw
Admin

I was told it could; check with @springmeyer and @incanus .

@springmeyer
Admin

target="_blank" should do it if I recall correctly. Are you seeing that is not the case on linux?

@ansis
Admin

I looks like it isn't possible to open it using javascript, window.open() isn't working for me. An issue in topcube?

A possible workaround is showing a dialog asking whether to open the link, and linking the ok button. Its not great, since it would be different behavior than on MapBox hosting.

@ansis
Admin

It looks like its actually an issue in webkitgtk and probably won't get fixed any time soon https://bugs.webkit.org/show_bug.cgi?id=23432

@tmcw
Admin

Could use window.location - I think the code way in the past had, and I think the _base attribute of the tilemill UI will make it open in a new window.

@ansis
Admin

window.location does not work for me, it opens within the webview. I'll try to look back, and see what could have changed.

@ansis ansis referenced this issue from a commit
@ansis ansis Location interaction, opens in new tab.
Does not work in gtk webview due to a signal bug.
Discussion in #1502
5c6d385
@incanus
Admin

Re: the new window behavior, we should be covered on OS X per these lines.

@springmeyer
Admin

Okay, location is now enabled in TileMill thanks to @aibram's pull request landing in #1542. The issue of how handling of a popup or new window behaves when TileMill is used not from a browser but from a native wrapper is a separate issue and can be handled at #1421. closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.