Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Use of HTML entities in text-name property causes "XML malformed" error #901

Closed
IvanSanchez opened this Issue · 5 comments

4 participants

@IvanSanchez

How to reproduce: get your favourite style and (inadvertely) put a HTML entity on a text-name property.

For example, this:

#route[type='plane']
{
  text-name: "'Avión'";
}

will work fine, but this:

#route[type='plane']
{
  text-name: "'Avión'";
}

returns a "Error: XML document not well formed: " error. In an ideal world, HTML entities should be no reason for crashing.

@springmeyer
Owner

@tmcw - could this be happening because CDATA is not being used in carto?

@tmcw
Owner

Yeah, it's not used in this instance, though I'm not sure if it'll fix both cases of this problem.

@willwhite
Owner

Removing from milestone.

@tmcw
Owner

Upstream in Carto: mapbox/carto#125

@tmcw
Owner

Fixed upstream in carto, fixed in 0.4.5 tag. HTML entities are not supported but won't cause crashes.

@tmcw tmcw closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.