[ui] Fix "*" link not working in carto reference (see mapbox/tilemill#1693) #1854

Merged
merged 1 commit into from Feb 25, 2013

2 participants

@yohanboniface

I run into this little annoying bug today, so here is a quick patch.

The "*" mapnik-reference symbolizer causes a section-* className to be created and then queried with jQuery selector, while * is a metacharacter for jQuery.

I'm not aware of some escape method in jQuery itself, hence some ad hoc solution seemed needed.
Thus, I've seen four solutions:

  • change value in mapnik-reference
  • fix input while importing it from mapnik-reference (say "*" become "all")
  • do a proper "selectorEscape" that escape every metacharacter and use it where needed (in view.toggler, almost)
  • just escape * where needed (in view.toggler)

Having no overview of tilemill internal, I thought the last solution was enough, but I may be wrong. ;)

Thanks!

Yohan

@springmeyer
Mapbox member

thanks for the patch, will apply shortly.

@springmeyer springmeyer merged commit df5e089 into mapbox:master Feb 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment