Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Interactivity problem with Leaflet in Chrome Canary #242

Closed
alperdincer opened this Issue · 14 comments

6 participants

@alperdincer

Hi,

I'm using Chrome Canary (22.0.1215.1) for development and I released that wax and leaflet don't work together on this browser.

You can check documentation page (http://mapbox.com/wax/interaction-leaf.html) on Chrome Canary to see what's going on.

Alper.

@tmcw
Admin

Can you see the problem in Chrome release cycle? This appears to work for me in Chrome Beta, and I'd rather not fix pre-release bugs in Chrome, of which there are many.

@alperdincer

There is no problem with Chrome Beta (version 21.0.1180.49 beta)

I just want to inform you about the issue.

Thanks a lot.

@tmcw
Admin

Thanks, hopefully Google catches it before it lands :)

@dooley

Unfortunatly not, Chrome Version 22.0.1229.79 (Win7) as well as latest stable version on Ubuntu has the problem from above. Any workaround?

@javierarce

Same thing in Chrome for mac. I'm currently using Chrome 22.0.1229.91 beta, but there are problems in the stable channel too.

@javisantana

the problem is with wax.offset, if you use $(el).offset return different values.

A quick fix (not tested in IE)

CartoDB@08b8247

@dooley

@ javisantana: Great, works without sideeffect in Chrome, Firefox, IE on Win7 (latest versions). Thanks for that!

@javisantana

@dooley thanks for testing.

also that fix solves some problems wax had with fixed positions on elements in the html page.

we have some testing for libraries that use wax, maybe is a good idea to "backport" them to wax to test this kind of things on different browser/OS/devices

@tmcw
Admin

@javisantana can you provide this as a pull request?

@javisantana

done

@tmcw
Admin

Pull request merged.

@tmcw tmcw reopened this
@miketahani

Fix worked for me, but it looks like the changes haven't made their way into dist/ on master. Thanks!

@javisantana

we have been using it extensively past months without any problem, i consider it fixed

@tmcw
Admin

Rebuilt and pushed in 1424765

@tmcw tmcw closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.