Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interaction function problem in Gmapsv3 #248

Closed
xavijam opened this issue Aug 22, 2012 · 6 comments
Closed

Remove interaction function problem in Gmapsv3 #248

xavijam opened this issue Aug 22, 2012 · 6 comments

Comments

@xavijam
Copy link

xavijam commented Aug 22, 2012

I'm trying to remove the interaction in Google maps, but it's failing.
Here is one of your examples:

http://vizzuality.github.com/cartodb-gmapsv3/wax-bug.html

If you try in the console:

interaction.remove();

Fails and say:

TypeError: Object # has no method 'remove'

PS: With Leaflet is working properly.

@wboykinm
Copy link

wboykinm commented Nov 1, 2012

I see Javier caught exactly the same issue I just stumbled on. using interaction.remove(); to push the next interactivity in a layer switcher results in the same TypeError: Object # has no method 'remove' error.

@wboykinm
Copy link

wboykinm commented Nov 1, 2012

I see that Javier 7 (how do you guys not get confused over there? - @javisantana) may have solved it. Here's his update to interaction.js. @tmcw or @willwhite - can either of you push this in tomorrow?

@javisantana
Copy link

@wboykinm hey, i didn't realize @xavijam was posted this bug. I found this some weeks ago, fixed it in out wax version and i forgot to send a pull request.

@willwhite
Copy link

Can you make a pull request with the fix?

@javisantana
Copy link

@willwhite sure, give a minute

@javisantana
Copy link

done #263

@tmcw tmcw closed this as completed in 95f03bf Nov 6, 2012
tmcw added a commit that referenced this issue Nov 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants