Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polygon editing tool improvements #1487

Open
bjorn opened this issue Mar 15, 2017 · 9 comments
Open

Polygon editing tool improvements #1487

bjorn opened this issue Mar 15, 2017 · 9 comments
Labels

Comments

@bjorn
Copy link
Member

@bjorn bjorn commented Mar 15, 2017

I implemented the polygon editing tool years ago and since then it hasn't received much love. However, there are several improvements that could be implemented to make it more useful:

  • Allow rotating of selected nodes
  • Allow scaling of selected nodes
  • Allow converting between polyline and polygon (open vs. closed)
  • Allow extending a polyline or polygon with more nodes (#157)
  • Add a faster way to split segments, by dragging from them or double-clicking them (splitting at interacted location).

For other possible improvements, see also #117, #145, #404, #762, #882 and #1555.

See also https://vectr.com/ (installable as snap on Linux) for common actions.

@bjorn bjorn added the feature label Mar 15, 2017
@ketanhwr
Copy link
Contributor

@ketanhwr ketanhwr commented Mar 28, 2017

@bjorn can we discuss more about this tool here? I was going through all the issues that you've mentioned, and it seemed to me that a lot of changes are to be made. That's why I was considering revamping this tool.

@bjorn
Copy link
Member Author

@bjorn bjorn commented Mar 28, 2017

@ketanhwr Sure. So far it seemed to me that these issues would all mean to extend the tool, but some things may raise questions. Please go into more detail about the things you consider needing a lot of changes.

@ketanhwr
Copy link
Contributor

@ketanhwr ketanhwr commented Aug 2, 2017

  • Allow rotating of selected nodes
  • Allow scaling of selected nodes

What does these two mean exactly?

@Ablu
Copy link
Contributor

@Ablu Ablu commented Aug 2, 2017

What does these two mean exactly?

I can think of those to, for example, rotate or scale a subset of the vertices of a polygon. I guess this is mostly useful for larger / complex polygons.

@bjorn
Copy link
Member Author

@bjorn bjorn commented Aug 2, 2017

Just see for example how when you select multiple objects, you can rotate and scale them as a group. The same functionality should be available for polygon nodes.

@JoeCreates
Copy link

@JoeCreates JoeCreates commented Jul 23, 2019

I think an important feature which is technically here but kind of gets lost among other issues in #762 is to allow the editing of individual points in properties. It would be useful to map the arrow keys to moving the currently selected node(s) in pixels, too.

A new suggestion is to allow for snapping to angles, e.g. 90, 45 degrees, or gradients of 1/2/3, perhaps with shift key.

I'm in a situation right now where I have no good option to make a straight flat line because my object is not aligned to the grid. I cannot reposition one of my nodes to the left while maintaining a flat line and put it in the right place for a moving platform (for which this line defines a path) to move to the correct place.

image

@bjorn
Copy link
Member Author

@bjorn bjorn commented Jul 24, 2019

I'm in a situation right now where I have no good option to make a straight flat line because my object is not aligned to the grid. I cannot reposition one of my nodes to the left while maintaining a flat line and put it in the right place for a moving platform (for which this line defines a path) to move to the correct place.

Right, in this case at the moment it could help to zoom in and to enable snapping to pixels. But I definitely agree that it would be good to add angle snapping and manual editing of point coordinates!

@anaanook
Copy link

@anaanook anaanook commented Oct 2, 2019

I think an important feature which is technically here but kind of gets lost among other issues in #762 is to allow the editing of individual points in properties. It would be useful to map the arrow keys to moving the currently selected node(s) in pixels, too.

adding a +1 here as I've been hitting this. There's currently inconsistency between what the arrow keys do when in select objects mode vs edit polygons mode - using the arrow keys to adjust positions. Arrow key adjustments in the polygon editing tool would be a fantastic addition.

@jjppof
Copy link

@jjppof jjppof commented Oct 30, 2020

I think an important feature which is technically here but kind of gets lost among other issues in #762 is to allow the editing of individual points in properties. It would be useful to map the arrow keys to moving the currently selected node(s) in pixels, too.

That would be a very awesome feature, mainly if we could use shift! +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants