Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the X key shortcut to flip an object horizontally is flipping vertically #1704

Closed
ArmagonNo1 opened this issue Aug 24, 2017 · 8 comments
Labels
bug Broken behavior. usability Generally about making something more intuitive or efficient.
Projects

Comments

@ArmagonNo1
Copy link

It has come to my attention that using the X key to flip an object horizontally is not working correctly. It visibly flips it horizontally as you'd expect, but it's actually setting a vertical flip in the object parameters. The only way I can presently get the horizontal flip I want is to use the checkbox. The Y key for vertical flipping appears to work perfectly fine.

flippingincorrectly

@bjorn
Copy link
Member

bjorn commented Aug 24, 2017

It looks visually alright because it also changes the rotation by 180 degrees and adjusts the position accordingly. This is the result of fixing the flipping of rotated objects and groups of objects, but I agree it leads to unexpected results in this case.

@huwpascoe
Copy link

Is there any way to map the 'X' key to just the horizontal checkbox?

@bjorn bjorn added the usability Generally about making something more intuitive or efficient. label Nov 30, 2020
@bjorn
Copy link
Member

bjorn commented Dec 1, 2020

Is there any way to map the 'X' key to just the horizontal checkbox?

No. I'll try to fix up this action, thanks for the reminder!

@finscn
Copy link

finscn commented Feb 15, 2022

@bjorn , this issue is still existing in 1.8.1

@bjorn bjorn added the bug Broken behavior. label Feb 15, 2022
@bjorn bjorn added this to Up Next in Roadmap Feb 15, 2022
@bjorn bjorn moved this from Up Next to Bugs in Roadmap Feb 15, 2022
@bjorn
Copy link
Member

bjorn commented Feb 15, 2022

this issue is still existing in 1.8.1

Yeah, sorry about that. It was one of the last issues remaining that I had scheduled for Tiled 1.8, but this release was already taking way too long so in the end I decided to drop it from the plan. And then 1.8.1 was really about getting a few serious regressions fixed.

Anyway, it's now on the list of bugs to look into soon.

@finscn
Copy link

finscn commented Mar 7, 2022

One thing I'm curious about this issue.
In my opinion , this issue is very easy to fix .
Why is it existing from 2017 to 2022 ?

Because it is hard to fix in fact ? or it's not a serious bug ?

@bjorn
Copy link
Member

bjorn commented Mar 30, 2022

In my opinion , this issue is very easy to fix . Why is it existing from 2017 to 2022 ?

Because it is hard to fix in fact ? or it's not a serious bug ?

@finscn Yes, it existed because it was in fact a very hard issue to solve, due to the different behavior for the various object types (tiles / rectangles / polygons) and on map orientations (orthogonal / isometric). But, I've spent about 1.5 days now on this, just for you! 😉 So, the behavior should be much better in Tiled 1.8.3.

If you can, please give it a round of testing based on the builds coming up at https://github.com/mapeditor/tiled/actions/runs/2065871063. Thanks!

@bjorn bjorn closed this as completed in 82ed841 Mar 30, 2022
Roadmap automation moved this from Bugs to Completed Mar 30, 2022
@finscn
Copy link

finscn commented Apr 21, 2022

I sorry , I haven't used tiledmap & github for the past few months . because my new project have to use ldTK.io.

Now, I've tried 1.8.4 . It's very very wonderful. Thanks & I love you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior. usability Generally about making something more intuitive or efficient.
Projects
Archived in project
Roadmap
  
Completed
Development

No branches or pull requests

4 participants