Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI buttons become darker each time you hover mouse pointer over them #2667

Closed
gerchicov-bp opened this issue Nov 14, 2019 · 12 comments
Closed
Labels
bug Broken behavior. macos macOS specific issue. qt issue Qt related issue.
Projects

Comments

@gerchicov-bp
Copy link

No description provided.

@bjorn
Copy link
Member

bjorn commented Nov 14, 2019

Please tell me which Tiled version, which operating system and which theme settings you're using. Also, did this work as intended before? If so, which version was that?

@bjorn bjorn added the bug Broken behavior. label Nov 14, 2019
@abrajam92
Copy link

Here, same problem with v1.3.0 on Mac OS 10.14.6, with the default theme and first use.

@bjorn bjorn added the macos macOS specific issue. label Nov 17, 2019
@bjorn
Copy link
Member

bjorn commented Nov 17, 2019

Thanks for the additional information, @abrajam92! Tagging this as macOS-specific until someone reports this also happening on other platforms. The default theme on macOS is "Native". Could you try if it also happens when using "Tiled Fusion"?

I'll try if this issue can also be seen on macOS 10.13. I can't test on more recent versions.

@cgh20xx
Copy link

cgh20xx commented Nov 18, 2019

I have same Issue. macOS Catalina 10.15.1

@bjorn
Copy link
Member

bjorn commented Nov 19, 2019

Unfortunately I can't reproduce this on macOS 10.13. Would somebody be able to provide a screenshot, or even better a short video capture of this problem? Would be useful to see the problem and also potentially to report the bug to the Qt framework, since this is unlikely to be a bug in Tiled.

@cgh20xx
Copy link

cgh20xx commented Nov 21, 2019

Unfortunately I can't reproduce this on macOS 10.13. Would somebody be able to provide a screenshot, or even better a short video capture of this problem? Would be useful to see the problem and also potentially to report the bug to the Qt framework, since this is unlikely to be a bug in Tiled.

截圖 2019-11-21 下午1 49 08

@bjorn
Copy link
Member

bjorn commented Nov 26, 2019

Alright, actually I do also see this issue on macOS 10.13, I just didn't realize the darker background only happens on the tools and then only for the selected one. Of course, that's because only selected buttons render this darker shade.

But, the root of the problem affects all buttons, and also causes for example icon shadows to become darker. It appears when a tool bar button is repainted, its background isn't. I doubt such a visible issue would affect a normal QMainWindow instance, but in Tiled there is a nested QMainWindow instance for each editor, which probably triggers the bug.

Note that the issue does not happen for floating tool bars, so you may want to float them for now. The issue also doesn't happen when you switch to the "Tiled Fusion" style in the Theme preferences.

@bjorn bjorn added the qt issue Qt related issue. label Nov 26, 2019
@bjorn bjorn added this to Tiled 1.3 (bugfixes) in Roadmap Nov 26, 2019
@bjorn
Copy link
Member

bjorn commented Nov 27, 2019

I noticed this issue is related to the use of a unified tool bar (it has a unified look along with the title bar). When I disable that the toolbar gets a gradient background and no longer has this bug.

However, disabling the unified tool bar triggers a different issue. Then the title bar appears to be slightly transparent but its blurred background is not updating when moving the window around. It only updates when resizing the window. It should be simply opaque. :-/

@AFlachat
Copy link

I can't reproduce this issue on macOS Catalina 10.15

@bjorn
Copy link
Member

bjorn commented Dec 17, 2019

I can't reproduce this issue on macOS Catalina 10.15

Did you potentially switch on OpenGL-accelerated rendering? Because since change f74edae this will disable the unified title and tool bar, which appears to also fix the background rendering issue as mentioned in my previous comment.

I guess we should just disable the unified title and tool bar for now and also report this rendering issue in Qt. It's easier to live with a title bar that has a little bit broken transparency (which is another thing that should be reported as a Qt bug).

@AFlachat
Copy link

I can't reproduce it with and without OpenGL-accelerated rendering.

@bjorn bjorn closed this as completed in 4f8f4bd Mar 31, 2020
Roadmap automation moved this from Tiled 1.3 (bugfixes) to Recently Completed Mar 31, 2020
@bjorn
Copy link
Member

bjorn commented Mar 31, 2020

I can't reproduce it with and without OpenGL-accelerated rendering.

After disabling OpenGL-accelerated rendering, you would need to restart Tiled to see this issue again. Maybe that's why you couldn't reproduce it without OpenGL-accelerated rendering.

In any case, I've now entirely disabled the unified title bar and tool bar. I think it looks a bit ugly, but that's better than having these painting issues. There's still the alternative to switch the Tiled theme to "Tiled Fusion" in the Preferences, which may look better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Broken behavior. macos macOS specific issue. qt issue Qt related issue.
Projects
Archived in project
Roadmap
  
Completed
Development

No branches or pull requests

5 participants