Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zstandard enabled by default on linux binary #2850

Closed
alphaonex86 opened this issue Jun 26, 2020 · 3 comments
Closed

Zstandard enabled by default on linux binary #2850

alphaonex86 opened this issue Jun 26, 2020 · 3 comments

Comments

@alphaonex86
Copy link
Contributor

Hi,

Zstandard can be enabled by default on linux binary?

Cheers,

@bjorn
Copy link
Member

bjorn commented Jun 27, 2020

It is already enabled by default for the AppImage that's published here on GitHub and on itch.io.

But it's not enabled by default for the snap, so I guess you're using that one? It seems zstd 1.3.3 is available on Ubuntu 18.04, so we could try to enable it based on that.

@bjorn
Copy link
Member

bjorn commented Jun 27, 2020

Three things that need to be addressed for this:

  • Add libzstd-dev to the build-packages and libzstd1 to the stage-packages in snap/snapcraft.yml.
  • Currently only the Qbs project file has an option to enable Zstandard, whereas the snap is built with qmake. So qmake project will need to be able to search for Zstandard and define TILED_ZSTD_SUPPORT, or snap needs to use Qbs.
  • Currently, only a custom Zstandard build is supported, not a system-installed one.

@bjorn bjorn closed this as completed in 73c01dd Jun 30, 2020
@bjorn
Copy link
Member

bjorn commented Jun 30, 2020

I'm closing this issue since I've pushed a change that should enable Zstandard in the snap and makes it possible to do so with a custom build by passing SYSTEM_ZSTD=yes to qmake on the command-line.

It is not enabled by default, however. To enable this by default, the project file would need to be modified to link to the library conditionally based on availability. If this is doable contributions are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants