Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting a selection causes the selection itself to go away #3281

Closed
Macksaur opened this issue Feb 21, 2022 · 5 comments
Closed

Deleting a selection causes the selection itself to go away #3281

Macksaur opened this issue Feb 21, 2022 · 5 comments

Comments

@Macksaur
Copy link

Problem

I am trying to delete a complex shape from a map and refill it with a different brush. However when I press delete to remove the underlying tiles the selection itself is also lost and I have to duplicate the work of selecting the complex shape.

Goal

To be able to fill a selection after it has been deleted.

@bjorn
Copy link
Member

bjorn commented Feb 21, 2022

Hmm, maybe the selection should only be removed when you Cut, and not when you Delete? I think the logic behind removing it on Cut was to make for a more comfortable Cut + Paste workflow to move things around, where you otherwise would have to manually get rid of the selection.

@bjorn
Copy link
Member

bjorn commented Feb 21, 2022

Note that to fill a selection, you generally do not have to delete it first. When using the Bucket Fill tool, you can hold Shift to fill it, regardless of its contents.

@eishiya
Copy link
Contributor

eishiya commented Feb 21, 2022

I think the current behaviour is best, as most of the time that's what's needed. It just happens to be very annoying in those few scenarios where it's not. It's also consistent with other editors.

Since Tiled supports Shift+Fill and deleting from multiple layers at once, there is even less need to keep the selection after deleting than there is in many other programs.

I can think of one scenario where it's still useful: when you want to clear a selection and then paint in part of it, while obeying the selection edges. I think being able to use a larger eraser or being able to Paint/Fill with the empty tile would be a better fix for this than changing the Delete behaviour.

@bjorn
Copy link
Member

bjorn commented Feb 21, 2022

It's also consistent with other editors.

Which ones did you try? I thought the same, but when I tried pressing Delete in GIMP 2.10, I noticed it actually does not remove the selection.

@eishiya
Copy link
Contributor

eishiya commented Feb 21, 2022

...you know what, I also thought so, but I was extremely wrong. Are we both from another universe? 🤣

Here's the behaviour for a selection of raster art programs based on my tests and an informal survey on Discord and Mastodon, sorted roughly by the amount of Keep vs Clear (-)

Program Delete Cut
Pyxel Edit Keep Keep
Krita Keep Keep
GIMP Keep Keep
CSP Keep Keep
Aseprite Keep -
Photoshop Keep -
SAI Keep -
Procreate - -
MS Paint - -

Tiled's in the good company of MS Paint and a mobile app 🤣

@bjorn bjorn closed this as completed in d72ae1b Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants