Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automapping output should be ignored if the output layer is locked #3544

Closed
dustinaux opened this issue Dec 12, 2022 · 3 comments · Fixed by #3562
Closed

Automapping output should be ignored if the output layer is locked #3544

dustinaux opened this issue Dec 12, 2022 · 3 comments · Fixed by #3562
Assignees
Labels
feature It's a feature, not a bug.

Comments

@dustinaux
Copy link

There could be a boolean added to the map or layer properties of a rule file that would override this, but I think the default should be locked layers are ignored, the opposite of what currently happens.

The current workaround is to duplicate the layer I don't want altered, run the automap, then delete the new output layer that was changed and rename my copy back to the correct layer name.

@dustinaux dustinaux added the feature It's a feature, not a bug. label Dec 12, 2022
@bjorn
Copy link
Member

bjorn commented Jan 18, 2023

I fear some people may be using the layer locking feature in order to prevent themselves from editing layers that their automapping rules are taking care of. As such I'm a bit weary of this change, even though I agree it makes a lot of sense.

At the very least an option to ignore layer locked status should indeed be provided when implementing this change.

Thanks for bringing this up!

@eishiya
Copy link
Contributor

eishiya commented Jan 19, 2023

+1 for an option for this! I often need both - I have some rules that I want to prevent by locking the output layer, and some rules that I want to run regardless of locked state. I currently have to rename layers to achieve what I need.

bjorn added a commit to bjorn/tiled-dev that referenced this issue Feb 3, 2023
Added SkipLocked option, which can be set to false to apply rules
to locked layers anyway.

Closes mapeditor#3544
@bjorn
Copy link
Member

bjorn commented Feb 3, 2023

I've opened a PR for this feature at #3562. Feedback is welcome!

bjorn added a commit to bjorn/tiled-dev that referenced this issue Feb 9, 2023
Added SkipLocked option, which can be set to false to apply rules
to locked layers anyway.

Closes mapeditor#3544
bjorn added a commit that referenced this issue Feb 9, 2023
Added IgnoreLock option, which can be set to true to apply rules
to locked layers anyway.

Also fixed cloning of layer locked status.

Closes #3544
@bjorn bjorn self-assigned this Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature It's a feature, not a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants