Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I'm a little bit surprised by that it automatically applies the move when I release the mouse button. Why doesn't it stay in a floating state, like the movement tool used to do?
Also I wonder if it's really needed to have Ctrl+Alt as modifier for this. I realize GIMP uses the same modifier, but they also handle just Alt for moving the selection without affecting the image. Either we could eventually also support Alt like that in Tiled, or we could try using just Alt for doing the drag. Or, we could try whether it would work without modifier, just going by "if you start dragging on the selection, without modifier". What do you think?
* Holding Alt is enough to do a drag. No need to click inside the selection. * Releasing either Alt or the mouse does not anchor the floating selection, so it can be dragged repeatedly. * The selection is anchored when the tool gets deactivated, you click outside of the floating selection or press Enter.
I've pushed a commit with several changes. Unfortunately, I still don't think we can merge this to
Maybe I'm making it too complicated by allowing repeated drags, but I think it needs to be supported because users will expect it to work and they will need it to work when they need to take the selection somewhere outside of their screen (or revert back to using copy/paste of course).
I think we should look again at other editors to see how they behave regarding such a feature.