Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QStandardPaths::findExecutable when executable is not a file #1648

Merged
merged 2 commits into from Jul 11, 2017

Conversation

@ketanhwr
Copy link
Contributor

@ketanhwr ketanhwr commented Jul 10, 2017

No description provided.

@bjorn
Copy link
Member

@bjorn bjorn commented Jul 10, 2017

I shortly tested this, but it didn't work. It is because QStandardPaths::findExecutable returns the full path of the located executable (including the file name), and this is not a valid working directory.

@bjorn bjorn merged commit 60e4314 into mapeditor:master Jul 11, 2017
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bjorn
Copy link
Member

@bjorn bjorn commented Jul 11, 2017

Well, you should always test things of course. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.