Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved docs #1701

Merged
merged 7 commits into from Aug 25, 2017
Merged

Improved docs #1701

merged 7 commits into from Aug 25, 2017

Conversation

@ketanhwr
Copy link
Contributor

@ketanhwr ketanhwr commented Aug 23, 2017

Adding and modifying docs for everything I've added in the past few months.

@ketanhwr ketanhwr changed the title Improved docs for custom command system Improved docs Aug 23, 2017
ketanhwr and others added 5 commits Aug 23, 2017
I also separated the substituted variables from the custom command
properties, since I thought it was confusing to name them under
"Executable" and then refer to there from the other properties.
@bjorn
Copy link
Member

@bjorn bjorn commented Aug 25, 2017

When I read the updated part about deletion of polygon nodes, I wondered if it was really a good idea to also allow entire object deletion when using the Edit Polygons Tool. I checked with Inkscape and they will only delete selected nodes when pressing this shortcut while using the "Edit paths by nodes" tool (unless you specially select the "Delete" action via the menu). Anyway I guess it doesn't matter much.

I'll merge this now in any case.

@bjorn bjorn merged commit 7931d94 into mapeditor:master Aug 25, 2017
0 of 2 checks passed
0 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
@bjorn bjorn added the documentation label Aug 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.