Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Scripting Function tiled.execute(command, arguments) #2966

Closed
wants to merge 2 commits into from

Conversation

fmoo
Copy link
Contributor

@fmoo fmoo commented Dec 18, 2020

Currently, there is no way to pass custom arguments from your
script to commands via tiled.executeCommand(). This change
implements a raw, tiled.execute() which takes the executable
and parameters as an argument, and runs that.

Obsoletes #2957

fmoo and others added 2 commits December 17, 2020 20:25
Currently, there is no way to pass custom arguments from your
script to commands via `tiled.executeCommand()`.  This change
implements a raw, `tiled.execute()` which takes the executable
and parameters as an argument, and runs that.

Obsoletes mapeditor#2957
@bjorn
Copy link
Member

bjorn commented Jan 6, 2021

Alright, so I considered this approach and I think we really should just expose a Process API as available in Qbs. It might be a bit more code to use, but it gives a lot more functionality. We can have a look at the code in Qbs4QJS. See also issue #2783.

@bjorn
Copy link
Member

bjorn commented Feb 24, 2021

Ah, I mentioned the wrong issue number. Anyway, this change is obsoleted by the new Process API added in f744572.

@bjorn bjorn closed this Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants