{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":26531519,"defaultBranch":"main","name":"OpenSfM","ownerLogin":"mapillary","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2014-11-12T10:47:29.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/5332499?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1684931570.149129","currentOid":""},"activityList":{"items":[{"before":"b18e63800126844b27c9d56d2da466c6a58c6d1f","after":"c9d7d98811568777d4ed35947ac040066c50782e","ref":"refs/heads/main","pushedAt":"2024-06-11T09:23:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add check to opensfm BA that GPS accuracies are positive\n\nSummary: For MLY internal we sometimes get -1 values for GPS accuracy. The new EXIF parser now prevents this from happening and sends None instead, but this diff adds an error message for this case so that we immediately notice if this ever happens again.\n\nReviewed By: DodgySpaniard\n\nDifferential Revision: D58373009\n\nfbshipit-source-id: 526d92fbec49be7a9a8398648d722880ab138d54","shortMessageHtmlLink":"add check to opensfm BA that GPS accuracies are positive"}},{"before":"40b73c08d4a7087a6d76033284eb6c66e1efe35f","after":"b18e63800126844b27c9d56d2da466c6a58c6d1f","ref":"refs/heads/main","pushedAt":"2024-06-03T08:53:21.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove dublicated SIFT-Dectector instance in feature matching (#1053)\n\nSummary:\nIt seems to me that the SIFT detector is instantiated, but then not used, because the object is created again in the following while loop. This merge request removes the unnecessary code.\nI have also made the missing parameters of the OpenCV-Sift implementation configurable.\n\nPull Request resolved: https://github.com/mapillary/OpenSfM/pull/1053\n\nReviewed By: paulinus\n\nDifferential Revision: D57765783\n\nPulled By: fabianschenk\n\nfbshipit-source-id: 59a24bbbc60f55c1cb5e1f81a9896ec13f82e5d8","shortMessageHtmlLink":"Remove dublicated SIFT-Dectector instance in feature matching (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2314635558\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mapillary/OpenSfM/issues/1053\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mapillary/OpenSfM/pull/1053/hovercard\" href=\"https://github.com/mapillary/OpenSfM/pull/1053\">#1053</a>)"}},{"before":"5b32e380a66e095894de82291087c674e0d6d3cd","after":"40b73c08d4a7087a6d76033284eb6c66e1efe35f","ref":"refs/heads/main","pushedAt":"2024-06-03T08:11:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"describe how to build and use docker images (#1049)\n\nSummary: Pull Request resolved: https://github.com/mapillary/OpenSfM/pull/1049\n\nReviewed By: paulinus\n\nDifferential Revision: D57765801\n\nPulled By: fabianschenk\n\nfbshipit-source-id: 6aa8c2678ac0007d42baa410b43077d4cccdd9ad","shortMessageHtmlLink":"describe how to build and use docker images (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2243753708\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mapillary/OpenSfM/issues/1049\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mapillary/OpenSfM/pull/1049/hovercard\" href=\"https://github.com/mapillary/OpenSfM/pull/1049\">#1049</a>)"}},{"before":"5e854bb43f046ac9277dcfc7a891bab8587f070f","after":"5b32e380a66e095894de82291087c674e0d6d3cd","ref":"refs/heads/main","pushedAt":"2024-04-18T19:45:47.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused pybind11 functions\n\nDifferential Revision: D56274720\n\nfbshipit-source-id: bd23cac89ee6df6190e8b847591ba2a12d8b4c66","shortMessageHtmlLink":"Remove unused pybind11 functions"}},{"before":"c72419228fb8c86f2c367989abd64f784ec684b3","after":"5e854bb43f046ac9277dcfc7a891bab8587f070f","ref":"refs/heads/main","pushedAt":"2024-04-03T00:54:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/mapillary` - batch 1\n\nDifferential Revision: D55650790\n\nfbshipit-source-id: e7eb7d1ee3f84943d28a1f893e75f58e9b4a67e1","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/mapillary</code> - batch 1"}},{"before":"4b562c6ab178b60d1f167dc2ec24d6dad8bb7aa6","after":"c72419228fb8c86f2c367989abd64f784ec684b3","ref":"refs/heads/main","pushedAt":"2024-03-22T01:41:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/mapillary` - batch 1\n\nDifferential Revision: D55201655\n\nfbshipit-source-id: a1eb370d0b39457e3f59614a093a50022869eca9","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/mapillary</code> - batch 1"}},{"before":"78b795c58a4684195c6c7ab5e7d531ee484f32c6","after":"4b562c6ab178b60d1f167dc2ec24d6dad8bb7aa6","ref":"refs/heads/main","pushedAt":"2024-03-18T17:09:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"returning norm_coords instead of px_coords in pixelToNormalizedCoordi… (#1031)\n\nSummary:\n…natesMany\n\nAttempting to fix issue create here: [https://github.com/mapillary/OpenSfM/issues/1030#issue-2046628484](https://github.com/mapillary/OpenSfM/issues/1030#issue-2046628484)\n\nPull Request resolved: https://github.com/mapillary/OpenSfM/pull/1031\n\nReviewed By: paulinus\n\nDifferential Revision: D55006764\n\nPulled By: fabianschenk\n\nfbshipit-source-id: 506078187c0f2387535521f0068c3322f2465b22","shortMessageHtmlLink":"returning norm_coords instead of px_coords in pixelToNormalizedCoordi… ("}},{"before":"afb0c15beacbf68890c3ddcadbb33186cc03f379","after":"78b795c58a4684195c6c7ab5e7d531ee484f32c6","ref":"refs/heads/main","pushedAt":"2024-03-07T19:02:44.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in mapillary/opensfm/opensfm/src/third_party/akaze/lib/AKAZE.cpp\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: dmm-fb\n\nDifferential Revision: D54378379\n\nfbshipit-source-id: 0a23b525ffbe0862e32609ce45af4c2cd7794551","shortMessageHtmlLink":"Remove unused variables in mapillary/opensfm/opensfm/src/third_party/…"}},{"before":"424ecc210ee468c0eab46a019d484ceaf4893a21","after":"afb0c15beacbf68890c3ddcadbb33186cc03f379","ref":"refs/heads/main","pushedAt":"2024-03-07T16:22:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix `-Wimplicit-const-int-float-conversion` violation in mapillary/opensfm/opensfm/src/geometry/relative_pose.h\n\nSummary:\n# Overview\n\nLLVM has detected a bad _implicit constant integer to float conversion_ in mapillary/opensfm/opensfm/src/geometry/relative_pose.h. Almost all such cases lead to very subtle bugs, so we are making them a compiler error by default.\n\n# Reproducer\n\nThe fix can be checked using:\n```\nbuck2 build --config cxx.extra_cxxflags=-Wimplicit-const-int-float-conversion <TARGET>\n```\n\n# Description of the problem\n\nWhat value do you think this produces?\n```\nstatic_cast<uint64_t>(static_cast<double>(std::numeric_limits<uint64_t>::max()))\n```\nYou'd hope it would produce UINT64_MAX (18446744073709551615), but it doesn't.\n\nIn debug mode it produces 9223372036854775808 (half of the above). In opt mode it produces \"random\" numbers such as 140726009322632 (which is 130,000x smaller than UINT64_MAX).\n\nComparisons between floats and maximum integer values are also scary:\n```\nconstexpr double x = std::numeric_limits<uint64_t>::max();\nconstexpr auto kMax64 = std::numeric_limits<uint64_t>::max();\nstd::cout << (x > kMax64 ? kMax64 : static_cast<uint64_t>(x)) << std::endl;\n```\nproduces garbage: 140731185888920\n\nThe reason this happens is because floating-point types can only represent integers sparsely in the regions of the maximum integers (generated with P1188399781):\n```\ndelta = 128\n2147483264 f\n2147483392 f\n2147483520 f\n2147483647 <- Largest integer\n2147483648 f\n2147483904 f\n2147484160 f\n\ndelta = 256\n4294966528 f\n4294966784 f\n4294967040 f\n4294967295 <- Largest integer\n4294967296 f\n4294967808 f\n4294968320 f\n\ndelta = 1024\n9223372036854772736 d\n9223372036854773760 d\n9223372036854774784 d\n9223372036854775807 <- Largest integer\n9223372036854775808 d\n9223372036854777856 d\n9223372036854779904 d\n\ndelta = 2048\n18446744073709545472 d\n18446744073709547520 d\n18446744073709549568 d\n18446744073709551615 <- Largest integer\n18446744073709551616 d\n18446744073709555712 d\n18446744073709559808 d\n```\n\n# Fixing the Problem\n\nSee example fixes in D54119898, D54119901, D54119899.\n\n## Careful Clamping\n\nThe fix will be situation dependent, `folly::constexpr_clamp_cast` is _very_ useful:\n```\n// Include the target `//folly:constexpr_math`\n#include <folly/ConstexprMath.h>\n#include <iostream>\n#include <limits>\n\nint main() {\n  constexpr auto kMax32 = std::numeric_limits<int32_t>::max();\n  std::cout << folly::constexpr_clamp_cast<int32_t>(static_cast<float>(kMax32)) << std::endl;\n  return 0;\n}\n```\n\n## Use infinity\n\nIn some cases we want want something like\n```\ndouble smallest_value = BIG_NUMBER;\nfor (const auto &x : values) {\n    smallest_value = std::min(smallest_value, x);\n}\n```\nIf `BIG_NUMBER` is an integer this code could be incorrect!\n\nInstead we use\n```\ndouble smallest_value = std::numeric_limits<double>::infinity();\n```\n\n## Make the conversion explicit\n\nFor situations in which we are dividing by a very large integer, we can use `static_cast<FLOAT_TYPE>(LARGE_INT)` to make the conversion from int to float explicit. The conversion is _not_ exact, but our hope is that the precision we've lost is small enough that it doesn't matter for the problem being solved.\n\nReviewed By: dmm-fb\n\nDifferential Revision: D54586517\n\nfbshipit-source-id: b03d0e05edc5dccff17811e8419548cfb72759b0","shortMessageHtmlLink":"Fix <code>-Wimplicit-const-int-float-conversion</code> violation in mapillary/op…"}},{"before":"938a3a169e66adb71949907fcf3ebca2089727a9","after":"424ecc210ee468c0eab46a019d484ceaf4893a21","ref":"refs/heads/main","pushedAt":"2024-03-06T16:10:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix `-Wimplicit-const-int-float-conversion` violation in mapillary/opensfm/opensfm/src/dense/src/depthmap.cc\n\nSummary:\n# Overview\n\nLLVM has detected a bad _implicit constant integer to float conversion_ in mapillary/opensfm/opensfm/src/dense/src/depthmap.cc. Almost all such cases lead to very subtle bugs, so we are making them a compiler error by default.\n\n# Reproducer\n\nThe fix can be checked using:\n```\nbuck2 build --config cxx.extra_cxxflags=-Wimplicit-const-int-float-conversion <TARGET>\n```\n\n# Description of the problem\n\nWhat value do you think this produces?\n```\nstatic_cast<uint64_t>(static_cast<double>(std::numeric_limits<uint64_t>::max()))\n```\nYou'd hope it would produce UINT64_MAX (18446744073709551615), but it doesn't.\n\nIn debug mode it produces 9223372036854775808 (half of the above). In opt mode it produces \"random\" numbers such as 140726009322632 (which is 130,000x smaller than UINT64_MAX).\n\nComparisons between floats and maximum integer values are also scary:\n```\nconstexpr double x = std::numeric_limits<uint64_t>::max();\nconstexpr auto kMax64 = std::numeric_limits<uint64_t>::max();\nstd::cout << (x > kMax64 ? kMax64 : static_cast<uint64_t>(x)) << std::endl;\n```\nproduces garbage: 140731185888920\n\nThe reason this happens is because floating-point types can only represent integers sparsely in the regions of the maximum integers (generated with P1188399781):\n```\ndelta = 128\n2147483264 f\n2147483392 f\n2147483520 f\n2147483647 <- Largest integer\n2147483648 f\n2147483904 f\n2147484160 f\n\ndelta = 256\n4294966528 f\n4294966784 f\n4294967040 f\n4294967295 <- Largest integer\n4294967296 f\n4294967808 f\n4294968320 f\n\ndelta = 1024\n9223372036854772736 d\n9223372036854773760 d\n9223372036854774784 d\n9223372036854775807 <- Largest integer\n9223372036854775808 d\n9223372036854777856 d\n9223372036854779904 d\n\ndelta = 2048\n18446744073709545472 d\n18446744073709547520 d\n18446744073709549568 d\n18446744073709551615 <- Largest integer\n18446744073709551616 d\n18446744073709555712 d\n18446744073709559808 d\n```\n\n# Fixing the Problem\n\nSee example fixes in D54119898, D54119901, D54119899.\n\n## Careful Clamping\n\nThe fix will be situation dependent, `folly::constexpr_clamp_cast` is _very_ useful:\n```\n// Include the target `//folly:constexpr_math`\n#include <folly/ConstexprMath.h>\n#include <iostream>\n#include <limits>\n\nint main() {\n  constexpr auto kMax32 = std::numeric_limits<int32_t>::max();\n  std::cout << folly::constexpr_clamp_cast<int32_t>(static_cast<float>(kMax32)) << std::endl;\n  return 0;\n}\n```\n\n## Use infinity\n\nIn some cases we want want something like\n```\ndouble smallest_value = BIG_NUMBER;\nfor (const auto &x : values) {\n    smallest_value = std::min(smallest_value, x);\n}\n```\nIf `BIG_NUMBER` is an integer this code could be incorrect!\n\nInstead we use\n```\ndouble smallest_value = std::numeric_limits<double>::infinity();\n```\n\n## Make the conversion explicit\n\nFor situations in which we are dividing by a very large integer, we can use `static_cast<FLOAT_TYPE>(LARGE_INT)` to make the conversion from int to float explicit. The conversion is _not_ exact, but our hope is that the precision we've lost is small enough that it doesn't matter for the problem being solved.\n\nReviewed By: YanNoun\n\nDifferential Revision: D54586527\n\nfbshipit-source-id: 6ac8812158f204457e002f2c3ec15b55d8fcb538","shortMessageHtmlLink":"Fix <code>-Wimplicit-const-int-float-conversion</code> violation in mapillary/op…"}},{"before":"7ad733935e0c81942e03d8f994844084a925372c","after":"938a3a169e66adb71949907fcf3ebca2089727a9","ref":"refs/heads/main","pushedAt":"2024-03-06T16:03:02.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix `-Wimplicit-const-int-float-conversion` violation in mapillary/opensfm/opensfm/src/features/src/matching.cc\n\nSummary:\n# Overview\n\nLLVM has detected a bad _implicit constant integer to float conversion_ in mapillary/opensfm/opensfm/src/features/src/matching.cc. Almost all such cases lead to very subtle bugs, so we are making them a compiler error by default.\n\n# Reproducer\n\nThe fix can be checked using:\n```\nbuck2 build --config cxx.extra_cxxflags=-Wimplicit-const-int-float-conversion <TARGET>\n```\n\n# Description of the problem\n\nWhat value do you think this produces?\n```\nstatic_cast<uint64_t>(static_cast<double>(std::numeric_limits<uint64_t>::max()))\n```\nYou'd hope it would produce UINT64_MAX (18446744073709551615), but it doesn't.\n\nIn debug mode it produces 9223372036854775808 (half of the above). In opt mode it produces \"random\" numbers such as 140726009322632 (which is 130,000x smaller than UINT64_MAX).\n\nComparisons between floats and maximum integer values are also scary:\n```\nconstexpr double x = std::numeric_limits<uint64_t>::max();\nconstexpr auto kMax64 = std::numeric_limits<uint64_t>::max();\nstd::cout << (x > kMax64 ? kMax64 : static_cast<uint64_t>(x)) << std::endl;\n```\nproduces garbage: 140731185888920\n\nThe reason this happens is because floating-point types can only represent integers sparsely in the regions of the maximum integers (generated with P1188399781):\n```\ndelta = 128\n2147483264 f\n2147483392 f\n2147483520 f\n2147483647 <- Largest integer\n2147483648 f\n2147483904 f\n2147484160 f\n\ndelta = 256\n4294966528 f\n4294966784 f\n4294967040 f\n4294967295 <- Largest integer\n4294967296 f\n4294967808 f\n4294968320 f\n\ndelta = 1024\n9223372036854772736 d\n9223372036854773760 d\n9223372036854774784 d\n9223372036854775807 <- Largest integer\n9223372036854775808 d\n9223372036854777856 d\n9223372036854779904 d\n\ndelta = 2048\n18446744073709545472 d\n18446744073709547520 d\n18446744073709549568 d\n18446744073709551615 <- Largest integer\n18446744073709551616 d\n18446744073709555712 d\n18446744073709559808 d\n```\n\n# Fixing the Problem\n\nSee example fixes in D54119898, D54119901, D54119899.\n\n## Careful Clamping\n\nThe fix will be situation dependent, `folly::constexpr_clamp_cast` is _very_ useful:\n```\n// Include the target `//folly:constexpr_math`\n#include <folly/ConstexprMath.h>\n#include <iostream>\n#include <limits>\n\nint main() {\n  constexpr auto kMax32 = std::numeric_limits<int32_t>::max();\n  std::cout << folly::constexpr_clamp_cast<int32_t>(static_cast<float>(kMax32)) << std::endl;\n  return 0;\n}\n```\n\n## Use infinity\n\nIn some cases we want want something like\n```\ndouble smallest_value = BIG_NUMBER;\nfor (const auto &x : values) {\n    smallest_value = std::min(smallest_value, x);\n}\n```\nIf `BIG_NUMBER` is an integer this code could be incorrect!\n\nInstead we use\n```\ndouble smallest_value = std::numeric_limits<double>::infinity();\n```\n\n## Make the conversion explicit\n\nFor situations in which we are dividing by a very large integer, we can use `static_cast<FLOAT_TYPE>(LARGE_INT)` to make the conversion from int to float explicit. The conversion is _not_ exact, but our hope is that the precision we've lost is small enough that it doesn't matter for the problem being solved.\n\nReviewed By: YanNoun\n\nDifferential Revision: D54586513\n\nfbshipit-source-id: 87fba3097e3822eb68660e0f2ab947eaf6450698","shortMessageHtmlLink":"Fix <code>-Wimplicit-const-int-float-conversion</code> violation in mapillary/op…"}},{"before":"8f618a2baf99589064f6eebb1c5018cda4dbfd43","after":"7ad733935e0c81942e03d8f994844084a925372c","ref":"refs/heads/main","pushedAt":"2024-03-02T18:26:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Pyre Configurationless migration for] [batch:26/112] [shard:6/N] (#1041)\n\nSummary:\nX-link: https://github.com/facebookincubator/metalos/pull/5\n\nX-link: https://github.com/facebookresearch/fbpcp/pull/527\n\nPull Request resolved: https://github.com/mapillary/OpenSfM/pull/1041\n\nReviewed By: connernilsen\n\nDifferential Revision: D54440273\n\nfbshipit-source-id: 0742c4b76bbef07c68a729f65bc27f1a176b919f","shortMessageHtmlLink":"Pyre Configurationless migration for] [batch:26/112] [shard:6/N] (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2164631614\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mapillary/OpenSfM/issues/1041\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mapillary/OpenSfM/pull/1041/hovercard\" href=\"https://github.com/mapillary/OpenSfM/pull/1041\">#1041</a>)"}},{"before":"4a74bc3b1f4043079099100e969e558d559acbfa","after":"8f618a2baf99589064f6eebb1c5018cda4dbfd43","ref":"refs/heads/main","pushedAt":"2024-02-28T12:58:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fix some indentation messed up by a codemod\n\nSummary: The previous diff failed to indent closing brackets.\n\nReviewed By: fabianschenk\n\nDifferential Revision: D54298641\n\nfbshipit-source-id: fff4bb610fad7ee64375f7182b3e4c177556af95","shortMessageHtmlLink":"fix some indentation messed up by a codemod"}},{"before":"21ed668ed496c5b4f7477e7985579b5112099a6a","after":"4a74bc3b1f4043079099100e969e558d559acbfa","ref":"refs/heads/main","pushedAt":"2024-02-28T11:17:01.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"mapillary (463897787004193082)\n\nReviewed By: paulinus\n\nDifferential Revision: D54105414\n\nfbshipit-source-id: a76d6dcd36c8d73a04ec93cfb8aabf2ca9eab2de","shortMessageHtmlLink":"mapillary (463897787004193082)"}},{"before":"68b18f309e743f8824c93616800ddaab64bba9e8","after":"21ed668ed496c5b4f7477e7985579b5112099a6a","ref":"refs/heads/main","pushedAt":"2024-02-15T00:53:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove semicolon(s) from 3 files inc mapillary/opensfm/opensfm/src/geometry/pose.h\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt` found an extra semi\n\nIf the code compiles, this is safe to land.\n\nReviewed By: palmje, dmm-fb\n\nDifferential Revision: D53776244\n\nfbshipit-source-id: 83a21ed4c3a954d7389b084a68912fe229bff40e","shortMessageHtmlLink":"Remove semicolon(s) from 3 files inc mapillary/opensfm/opensfm/src/ge…"}},{"before":"072abf02f58b923d74736277c1e15af4de8c0162","after":"68b18f309e743f8824c93616800ddaab64bba9e8","ref":"refs/heads/main","pushedAt":"2024-02-15T00:30:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in mapillary/opensfm/opensfm/src/foundation/newton_raphson.h\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D53779594\n\nfbshipit-source-id: a22fbbc945140165686a74c9d0c921983ca54451","shortMessageHtmlLink":"Remove unused variables in mapillary/opensfm/opensfm/src/foundation/n…"}},{"before":"2281fd434989b28ff5c7161c389c09a111956f8d","after":"072abf02f58b923d74736277c1e15af4de8c0162","ref":"refs/heads/main","pushedAt":"2024-02-15T00:20:40.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused variables in mapillary/opensfm/opensfm/src/geometry/pose.h\n\nSummary:\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.\n\nThis diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje\n\nDifferential Revision: D53779585\n\nfbshipit-source-id: d651d6b4cf4dbc777f924f936e9325005c80d2ba","shortMessageHtmlLink":"Remove unused variables in mapillary/opensfm/opensfm/src/geometry/pose.h"}},{"before":"013956c43ffb95605845ff1858e645a00ed66e98","after":"2281fd434989b28ff5c7161c389c09a111956f8d","ref":"refs/heads/main","pushedAt":"2024-02-14T21:50:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove semicolon(s) from 3 files inc mapillary/opensfm/opensfm/src/geometry/camera.h\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt` found an extra semi\n\nIf the code compiles, this is safe to land.\n\nReviewed By: palmje, dmm-fb\n\nDifferential Revision: D53776237\n\nfbshipit-source-id: eb4d82dc16f32e4276887e025d29b701d3333811","shortMessageHtmlLink":"Remove semicolon(s) from 3 files inc mapillary/opensfm/opensfm/src/ge…"}},{"before":"bec57f3075bb3f2ef0e7c2a29ad4d877cc1bd1d3","after":"013956c43ffb95605845ff1858e645a00ed66e98","ref":"refs/heads/main","pushedAt":"2024-02-14T21:34:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove semicolon(s) from 3 files inc loki/lacis/storage/rtree/liveindex/LokiShard.h\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt` found an extra semi\n\nIf the code compiles, this is safe to land.\n\nReviewed By: palmje, dmm-fb\n\nDifferential Revision: D53776073\n\nfbshipit-source-id: 99e769877dd17b6ddb51e82cf48d7605668cafb7","shortMessageHtmlLink":"Remove semicolon(s) from 3 files inc loki/lacis/storage/rtree/liveind…"}},{"before":"a848b1f47a71da6c96dee666245ed9253ec69aa0","after":"bec57f3075bb3f2ef0e7c2a29ad4d877cc1bd1d3","ref":"refs/heads/main","pushedAt":"2024-01-27T03:11:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"suppress errors in `mapillary/opensfm`\n\nDifferential Revision: D53151206\n\nfbshipit-source-id: 04c3b8f4766a2d749b2471038e3cb1cd9b877f5d","shortMessageHtmlLink":"suppress errors in <code>mapillary/opensfm</code>"}},{"before":"569f6d3a287178872277d7adcae1f5cb6eba92e3","after":"a848b1f47a71da6c96dee666245ed9253ec69aa0","ref":"refs/heads/main","pushedAt":"2024-01-26T03:22:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"suppress errors in `mapillary/opensfm`\n\nDifferential Revision: D53099888\n\nfbshipit-source-id: 2dc5a3bf14b2e97958f394f87f8dc4fb8bc1a851","shortMessageHtmlLink":"suppress errors in <code>mapillary/opensfm</code>"}},{"before":"7f170d0dc352340295ff480378e3ac37d0179f8e","after":"569f6d3a287178872277d7adcae1f5cb6eba92e3","ref":"refs/heads/main","pushedAt":"2024-01-08T11:05:07.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Rename variable to avoid shadowing\n\nSummary: This is a better renaming of what was proposed in D52582811.\n\nReviewed By: YanNoun\n\nDifferential Revision: D52596501\n\nfbshipit-source-id: 17a4b2e3b17a2040908d16c007cea3556c7302bf","shortMessageHtmlLink":"Rename variable to avoid shadowing"}},{"before":"d787a1811be3eda610090af3741c4a618e73f375","after":"7f170d0dc352340295ff480378e3ac37d0179f8e","ref":"refs/heads/main","pushedAt":"2023-12-09T02:26:05.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove extra semi colon from luna/common/sampling/samplers/StatsWrapper.cpp\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt`\n\nIf the code compiles, this is safe to land.\n\nReviewed By: palmje\n\nDifferential Revision: D51995049\n\nfbshipit-source-id: 441e8695a7d4c68d715c87a7704fa54bda53f6ab","shortMessageHtmlLink":"Remove extra semi colon from luna/common/sampling/samplers/StatsWrapp…"}},{"before":"6a1f95ec626f63668afe09af2b0c1cccde4c9700","after":"d787a1811be3eda610090af3741c4a618e73f375","ref":"refs/heads/main","pushedAt":"2023-12-08T23:45:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove extra semi colon from mapillary/opensfm/opensfm/src/geo/geo.h\n\nSummary:\n`-Wextra-semi` or `-Wextra-semi-stmt`\n\nIf the code compiles, this is safe to land.\n\nReviewed By: palmje\n\nDifferential Revision: D51995097\n\nfbshipit-source-id: 473fa063cd47983e6e99a85c112fb51af0ea6719","shortMessageHtmlLink":"Remove extra semi colon from mapillary/opensfm/opensfm/src/geo/geo.h"}},{"before":"925d7ffe327026d4afb0eb75134090f9f8c63a8d","after":"6a1f95ec626f63668afe09af2b0c1cccde4c9700","ref":"refs/heads/main","pushedAt":"2023-12-08T19:16:36.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add progress plotting to correspondence copier and opensfm.reconstructor\n\nSummary:\nTo make it easier to track reconstruction progress in larger jobs, this diff adds\n- logging to the `opensfm.reconstructor` how many shots we already have in a map\n- `tqdm` logging to the most expensive loops of the `copy_view_correspondences_between_pose_graph_and_component` module.\n\nDifferential Revision: D51964593\n\nfbshipit-source-id: 08a4e81f6464329da01ba78e41d5142c7db0e848","shortMessageHtmlLink":"add progress plotting to correspondence copier and opensfm.reconstructor"}},{"before":"98939bf06a7a777415c97db380fd110cc36043b7","after":"925d7ffe327026d4afb0eb75134090f9f8c63a8d","ref":"refs/heads/main","pushedAt":"2023-12-07T07:12:59.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"upgrade pyre version in `fbcode/mapillary` - batch 1\n\nDifferential Revision: D51900922\n\nfbshipit-source-id: 4d2baa2ad4b8555fbe1ef33e2ebaedb64bdcac4b","shortMessageHtmlLink":"upgrade pyre version in <code>fbcode/mapillary</code> - batch 1"}},{"before":"25c04c334001c2316d946c3c63ef5a1b4054ca90","after":"98939bf06a7a777415c97db380fd110cc36043b7","ref":"refs/heads/main","pushedAt":"2023-11-14T14:41:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"mapillary\n\nReviewed By: zsol\n\nDifferential Revision: D51300169\n\nfbshipit-source-id: 30cf2084197dbe6f30d499e06e0f09674d761bad","shortMessageHtmlLink":"mapillary"}},{"before":"fb3dc964854a08d7cd6aa1c7ef98dd5fe419c4ce","after":"25c04c334001c2316d946c3c63ef5a1b4054ca90","ref":"refs/heads/main","pushedAt":"2023-11-10T22:13:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add gopro max fisheye to hardcoded_camera_calibration\n\nSummary: with this we no longer need to manually set calibration in UVP\n\nDifferential Revision: D51165336\n\nfbshipit-source-id: 85804043986ef9520694e9dd788efbc7223420d9","shortMessageHtmlLink":"add gopro max fisheye to hardcoded_camera_calibration"}},{"before":"c6b5acef9376a75b87414d900c258ef876a6413a","after":"fb3dc964854a08d7cd6aa1c7ef98dd5fe419c4ce","ref":"refs/heads/main","pushedAt":"2023-11-06T21:21:55.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add logs for number of GPS constraints in OpenSFM\n\nSummary: Loggs to test Enable/Disable GPS in OpenSFM\n\nDifferential Revision: D50942543\n\nfbshipit-source-id: ba2c001179a5d07d25917adf7b4abdb517f6d5a7","shortMessageHtmlLink":"Add logs for number of GPS constraints in OpenSFM"}},{"before":"c798da16206aa52395eaef09ea4d7746028479d3","after":"c6b5acef9376a75b87414d900c258ef876a6413a","ref":"refs/heads/main","pushedAt":"2023-09-15T08:59:19.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Image channels dimension and dtype check for feature extraction. (#1018)\n\nSummary: Pull Request resolved: https://github.com/mapillary/OpenSfM/pull/1018\n\nReviewed By: paulinus\n\nDifferential Revision: D48945121\n\nPulled By: fabianschenk\n\nfbshipit-source-id: b1b1b51640dd82d9de98e59de8d09c054641a6b7","shortMessageHtmlLink":"Image channels dimension and dtype check for feature extraction. (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1879200726\" data-permission-text=\"Title is private\" data-url=\"https://github.com/mapillary/OpenSfM/issues/1018\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/mapillary/OpenSfM/pull/1018/hovercard\" href=\"https://github.com/mapillary/OpenSfM/pull/1018\">#1018</a>)"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEYgJYOwA","startCursor":null,"endCursor":null}},"title":"Activity · mapillary/OpenSfM"}