Apple M1 changes #788
Apple M1 changes #788
Conversation
|
@fabianschenk has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
| @@ -68,7 +68,11 @@ std::pair<bool, Eigen::Matrix<T, 3, 1>> TriangulateTwoBearingsMidpointSolve( | |||
|
|
|||
| const T eps = T(1e-30); | |||
| const T det = A.determinant(); | |||
| #ifdef __aarch64__ | |||
| if (std::abs<T>(det) < eps) { | |||
There was a problem hiding this comment.
@pierotofy
Thanks for your diff. Could you remove the #ifdef and simply use the templated version as default:
if (std::abs<T>(det) < eps)
There was a problem hiding this comment.
Hey @fabianschenk ✋ thanks for the review, I actually started out by just having the templated version, but Visual Studio doesn't like it (read: it doesn't compile) on Windows.
I could replace the define to a #ifndef __MSVC__ ?
There was a problem hiding this comment.
Hi @pierotofy ,
Thanks for the quick response and also for testing on Windows.
Then I'll land it like it is.
Thanks again for your contribution 👍
There was a problem hiding this comment.
Pleasure! OpenSfM is a great software.
|
@fabianschenk merged this pull request in d468471. |
Hey all ✋
While building and running OpenSfM on an Apple M1 I encountered a strange bug, which I narrowed down to to
geometry/triangulation.h:71. Debugging a reconstruction showed that for some reason the compiler decided to assume std::abs should be of typeintinstead of typeT, causing values to be truncated to0at every computation.