Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fullscreenstart, fullscreenend events to FullscreenControl #2128

Merged
merged 6 commits into from Feb 3, 2023
Merged

Add fullscreenstart, fullscreenend events to FullscreenControl #2128

merged 6 commits into from Feb 3, 2023

Conversation

kevinschaul
Copy link
Contributor

@kevinschaul kevinschaul commented Feb 2, 2023 •
edited

I need to make some adjustments to a map when it enters or exits fullscreen mode. Currently there is no way to track when fullscreen status changes.

I think this may also help with the implementation of #1487

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@kevinschaul
Add start, end events to FullscreenControl
f7094cf 
These are useful for adjusting map settings or styles depending on
whether the map is in fullscreen or not.

This also may help implement maplibre#1487
@kevinschaul
Merge branch 'maplibre:main' into fullscreen-events
8d67cb9
@HarelM
Copy link
Member

HarelM commented Feb 2, 2023

Thanks for taking the time to open this PR!

@HarelM
Copy link
Member

HarelM commented Feb 3, 2023

Thanks!! If you feel like redoing #1487 it would be great (opening a different PR as I didn't get any response to my comments there)

@HarelM HarelM merged commit ff99b07 into maplibre:main Feb 3, 2023
@kevinschaul
Copy link
Contributor Author

Thank you!

@elgandoz elgandoz mentioned this pull request Dec 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarelM HarelM HarelM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinschaul @HarelM