Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy fixes #206

Merged
merged 5 commits into from Nov 12, 2022
Merged

Clippy fixes #206

merged 5 commits into from Nov 12, 2022

Conversation

julienr
Copy link
Contributor

@julienr julienr commented Nov 11, 2022

Fixes a number of clippy issues:

  • Implement Default for various types
  • Remove some useless format/mut
  • Simplify some if let match
  • Fix some cases where variables are never read because they are immediatly overwritten

Copy link
Member

@nyurik nyurik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@julienr
Copy link
Contributor Author

julienr commented Nov 11, 2022

Looks like the build is failing because some dependencies require rust 1.65:

Caused by:
  package `wgpu-hal v0.14.0 (/home/runner/.cargo/git/checkouts/wgpu-53e70f8674b08dd4/d536613/wgpu-hal)` cannot be built because it requires rustc 1.65 or newer, while the currently active rustc version is 1.64.0

I guessed this is blocked by #201 then ?

@nyurik
Copy link
Member

nyurik commented Nov 11, 2022

@julienr 🤷 I think @maxammann would have to answer that. Or you could try to tackle #201?

@maxammann
Copy link
Collaborator

Its a new issue :) Ill fix it today propably.

@maxammann
Copy link
Collaborator

I'll merge as soon as checks succeed: #207

@maxammann maxammann enabled auto-merge (squash) November 12, 2022 12:22
@maxammann maxammann merged commit c77ce85 into maplibre:main Nov 12, 2022
@julienr julienr deleted the clippy-fixes branch November 12, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants