feat: use latest actix, switch to bb8 (async everywhere), remove actions #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump actix dependencies to the latest versions The server.rs `fn new(pool, config)` needs more work because the new `HttpServer::new` returns a future that needs to be awaited. I am not an expert in actix, and I'm not certain why `actix::System::new()` was being returned before, and if its still needed. Some help is welcome.
nyurik
changed the title
stepankuzmin
reviewed
Aug 9, 2022
|
I think we can drop the refresh functionality from the app for now. Let's notify users that this feature was removed when the watch mode cli arg or env var is detected as |
|
@stepankuzmin thx, good point, removed both. I think eventually we may want to revisit the watch support, so I wonder if it would make sense to remove watch support as a separate PR? this would make it easier to review this PR and easier to revert the watch removal if needed. |
|
@nyurik yep, that would be more convenient, thanks! |
This reverts commit 920cabe.
@stepankuzmin see #381 - which should be merged before this one. |
nyurik
changed the title
nyurik
changed the title
|
@stepankuzmin ok, done with the changes, let me know if this needs any other changes |
stepankuzmin
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #349