Skip to content

Commit 1a4bb0a

Browse files
committed
fix(api v3): changed logic to determine default values
default values are now applied when parameters are on the request but left empty
1 parent 22c9d9d commit 1a4bb0a

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

app/Http/Controllers/API/v3/FontAwesome/v6/IconController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ class IconController extends Controller
1313
public function show(Request $request)
1414
{
1515
// GET MARKER CONFIG
16-
$markerSize = $request->get('size', 100);
17-
$markerColor = '#'.$request->get('color', '333');
16+
$markerSize = $request->get('size') ?: 100;
17+
$markerColor = '#'.$request->get('color', ) ?: '333';
1818

1919
// GET ICON
2020
$iconMarkup = GetIconMarkup::run($request->get('icon', ''));

app/Http/Controllers/API/v3/FontAwesome/v6/IconStackController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,11 +12,11 @@ class IconStackController extends Controller
1212
public function show(Request $request)
1313
{
1414
// GET MARKER CONFIG
15-
$markerSize = $request->get('size', 100);
15+
$markerSize = $request->get('size') ?: 100;
1616

1717
// FOREGROUND ICON
1818
$foregroundIcon = $request->get('icon') ?: null;
19-
$foregroundIconColor = '#'.$request->get('color', '000');
19+
$foregroundIconColor = '#'.$request->get('color') ?: '000';
2020
$foregroundIconMarkup = GetIconMarkup::run($foregroundIcon);
2121

2222
// FOREGROUND ICON SHIFTING

app/Http/Controllers/API/v3/FontAwesome/v6/PinController.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@ public function show(Request $request)
2121
protected function showIconPin(Request $request)
2222
{
2323
// GET MARKER CONFIG
24-
$markerSize = $request->get('size', 100);
24+
$markerSize = $request->get('size') ?: 100;
2525

2626
// FOREGROUND ICON
2727
$foregroundIcon = $request->get('icon') ?: null;
28-
$foregroundIconColor = '#'.$request->get('color', 'FFF');
28+
$foregroundIconColor = '#'.$request->get('color') ?: 'FFF';
2929
$foregroundIconMarkup = GetIconMarkup::run($foregroundIcon);
3030

3131
// FOREGROUND ICON SHIFTING

0 commit comments

Comments
 (0)