Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

remove locking around pj_transform for proj 4.7 #1072

Closed
springmeyer opened this Issue · 2 comments

2 participants

@springmeyer
Owner

Mutex locking was introduced around pj_transform to protect against the possibility of crashes a long time ago: http://comments.gmane.org/gmane.comp.gis.mapnik.devel/462

We now avoid this locking if proj 4.8 (current unreleased trunk) is detected, but I think we should do the same for 4.7.

My hunch is that the original problems were likely encountered due to pj_init (which proj 4.7 now protects against) and not pj_transform as I am unable to prompt crashes in unprotected pj_transform with proj 4.7 within TileMill, which uses multithreaded rendering.

This move is valuable because proj development is stalled and so linux systems relying on packages are stuck at 4.7 leading to cases for mapnik where multithreaded rendering is extremely slow.

@springmeyer
Owner

found a case, only replicable on linux, where this is not going to fly and causes cascading proj_init errors. So, reverted.

@alno

Thank you, you save my day! Just met a lot of random proj_init errors (and broken tiles) after using datasources with different projections in TileMill. After updating work like a charm =)

@strk strk referenced this issue from a commit in strk/mapnik
@springmeyer springmeyer Revert "avoid mutex locks on pj_transform for proj 4.7 and above - cl…
…oses #1072"

This reverts commit 150c9f8.
0be7d66
@zerebubuth zerebubuth referenced this issue from a commit in MapQuest/mapnik
@springmeyer springmeyer Revert "avoid mutex locks on pj_transform for proj 4.7 and above - cl…
…oses #1072"

This reverts commit 0748d2b.
7c52960
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.