Skip to content

Loading…

renderer detector type consistency #1107

Closed
springmeyer opened this Issue · 3 comments

3 participants

@springmeyer
Mapnik member

agg renderer uses a boost::shared_ptr to hold the detector: boost::shared_ptr<label_collision_detector4> detector_; while cairo and grid renderer don't. we should be consistent.

@artemp
Mapnik member

Yes, we should provide consistent interface. agg_renderer expects LabelCollisionDetector but cairo/grid aren't - guessing this is a work-in-progress @herm ?

@herm
Mapnik member

The change was done in b5c4bb7. I didn't touch collision detector at all.

@sigmapi sigmapi added a commit to sigmapi/mapnik that referenced this issue
@sigmapi sigmapi Exposed the label collision detector outside of Cairo renderer and ad…
…ded Python bindings (issue #1107)
e34dc99
@springmeyer
Mapnik member

cairo updated in #1444 and grid was updated a while back, closing.

@springmeyer springmeyer closed this
@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue
@sigmapi sigmapi Exposed the label collision detector outside of Cairo renderer and ad…
…ded Python bindings (issue #1107)
bcd1af7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.