Skip to content
This repository

renderer detector type consistency #1107

Closed
springmeyer opened this Issue February 27, 2012 · 3 comments

3 participants

Dane Springmeyer Artem Pavlenko Hermann Kraus
Dane Springmeyer
Owner

agg renderer uses a boost::shared_ptr to hold the detector: boost::shared_ptr<label_collision_detector4> detector_; while cairo and grid renderer don't. we should be consistent.

Artem Pavlenko
Owner

Yes, we should provide consistent interface. agg_renderer expects LabelCollisionDetector but cairo/grid aren't - guessing this is a work-in-progress @herm ?

Hermann Kraus
Collaborator
herm commented March 11, 2012

The change was done in b5c4bb7. I didn't touch collision detector at all.

Panagiotis Skintzos sigmapi referenced this issue from a commit in sigmapi/mapnik August 25, 2012
Panagiotis Skintzos Exposed the label collision detector outside of Cairo renderer and ad…
…ded Python bindings (issue #1107)
e34dc99
Dane Springmeyer
Owner

cairo updated in #1444 and grid was updated a while back, closing.

Dane Springmeyer springmeyer closed this October 03, 2012
PetrDlouhy PetrDlouhy referenced this issue from a commit in PetrDlouhy/mapnik August 25, 2012
Panagiotis Skintzos Exposed the label collision detector outside of Cairo renderer and ad…
…ded Python bindings (issue #1107)
bcd1af7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.