Provide pixel resolution tokens to subselects #1181

Closed
strk opened this Issue Apr 18, 2012 · 7 comments

Comments

Projects
None yet
2 participants
Contributor

strk commented Apr 18, 2012

Following vector reduction work of #1136 this ticket is to provide pixel resolution tokens to users willing to do custom simplifications based on that. px_gw and px_gh were proposed by Dane in that ticket. That'd be fine with me.

Owner

springmeyer commented Apr 18, 2012

I'm not convinced those are the best names - would be good to consider some alternatives.

Contributor

strk commented Apr 18, 2012

!pixel_width! !pixel_height!

Contributor

strk commented Apr 23, 2012

I see there are two version of the postgis_datasource::populate_tokens method. One takes no token values, the other takes each of the token values. Why the duplication ?

Owner

springmeyer commented Apr 23, 2012

one is used when the replacement tokens are not known (but the subquery still needs to be executed to be able to grab metadata).

Contributor

strk commented Apr 24, 2012

On Mon, Apr 23, 2012 at 04:48:36PM -0700, Dane Springmeyer wrote:

one is used when the replacement tokens are not known (but the subquery still needs to be executed to be able to grab metadata).

What kind of metadata ? Would such metadata still be meaningful while
replacing tokens with arbitrary values ?

--strk;

,------o-.
| __/ | Delivering high quality PostGIS 2.0 !
| / 2.0 | http://strk.keybit.net - http://vizzuality.com
`-o------'

strk pushed a commit to strk/mapnik that referenced this issue Apr 24, 2012

springmeyer pushed a commit that referenced this issue Apr 30, 2012

Merge pull request #1192 from strk/master-pixelsize-tokens
Provide !pixel_width! and !pixel_height! tokens (#1181)
Owner

springmeyer commented Jul 3, 2012

closing, this was handled by #1192

@springmeyer springmeyer closed this Jul 3, 2012

Contributor

strk commented Jul 3, 2013

There seems to be a bug in the implementation of this. Too bad it lacked an automated testcase.
The width of a pixel in geographical units seem to be augmenting rather than diminishing as the output size augments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment