maintain compatibility with all initial raster compositing modes? #1206

Closed
springmeyer opened this Issue May 10, 2012 · 5 comments

Comments

Projects
None yet
2 participants
Owner

springmeyer commented May 10, 2012

With c469a63, the new work on core compositing replaced the older initial implementation of compositing for rasters-only. This change should behave very similarly, but a few of the mode names previously supported are now removed:

grain_merge
grain_merge2
multiply2
divide2

All current supported compositing modes are at https://github.com/mapnik/mapnik/blob/master/include/mapnik/image_compositing.hpp#L40-70

We need to discuss with Marcin if dropping these is okay, or if there is a good reason to support them.

@springmeyer
We are using grain_merge mode on the map with hillshade: http://kosmosnimki.ru/permalink.html?Nfbc1062b

Owner

springmeyer commented Jun 6, 2012

grain-merge added back (by implementing with agg) in 6bea57d. and also grain-extract added in f3c774b

Thanks!

@springmeyer springmeyer pushed a commit that referenced this issue Jun 6, 2012

Dane Springmeyer remove now unused blending modes as they have been replaced with AGG …
…compositing modes - refs #1206
7621124
Owner

springmeyer commented Jun 6, 2012

finished with 7621124, closing.

springmeyer closed this Jun 6, 2012

@springmeyer springmeyer pushed a commit that referenced this issue Aug 23, 2012

Dane Springmeyer finish full back comptibility for raster-mode - refs #1206 and #1432 23808b0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment