resolve span_image_resample_rgba_affine changes #1227

Closed
springmeyer opened this Issue May 24, 2012 · 3 comments

2 participants

@springmeyer
Mapnik member

We currently keep a local impl of mapnik::span_image_resample_rgba_affine to maintain proper alpha blending during scaling: 983db00, which (re) fixed #997 and maintains the fix for #759. Here is its diff against agg 2.4: https://gist.github.com/2784202

We also have a modified agg:span_image_resample_rgba_affine. Here it its diff again agg 2.4: https://gist.github.com/2784213. I think this was was modified incorrectly.

I'd like to revert the modified agg sources, since we implement our own and having modified source in this case can only cause to confuse. This issue serves to document the decision.

@springmeyer
Mapnik member

ugh, 225678e was a mistake, 19631e5 was the intended rollback of local mods to agg.

@springmeyer
Mapnik member

@artemp - only other action needed is for you to sign off on this as looking okay, then we can close.

@artemp
Mapnik member

@springmeyer - looks good, closing.

@artemp artemp closed this May 25, 2012
@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013
@springmeyer springmeyer rollback 1b4e7a8 - refs #1489 and #1227 15f1cdd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment