Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

support scaling of point images and line/polygon image patterns #1279

Closed
springmeyer opened this Issue · 13 comments

4 participants

@springmeyer
Owner

Line and polygon pattern symbolizers need to support the render time scale_factor, and both pattern symbolizers and the point symbolizer need to support the transform.scale property (which only right now works with svg symbols).

This is as followup on #1274 (and #695)

See also #952

@artemp artemp was assigned
@artemp
Owner

@springmeyer - we should support affine_transforms for images. AGG has got all required pieces.

@springmeyer
Owner

@artemp - yes, sounds good - though I think just supporting .scale() should be considered if full affine transforms are hard to get done before release, given that scaling is the only commonly requested feature for bitmap images.

@artemp
Owner

195b8ad - affine transform for raster markers (PointSymbolizer atm)

@JeroenVu

@artemp Hi, I'm getting raster markers that seem te be scaled twice when using scale_factor. I think this is related to commit 195b8ad, but I can't exactly tell what's wrong.

@artemp
Owner

@JeroenVu - could you post .xml style, thanks ?

@lightmare

The problem could be that process(point_symbolizer) calls render_marker (src/agg/process_point_symbolizer.cpp +97) with pre-scaled transformation matrix (src/agg/process_point_symbolizer.cpp +72), while other calls pass raw image-transform matrix.

@artemp
Owner

@lightmare @JeroenVu - yep, I can replicate it

@artemp
Owner

@JeroenVu @lightmare - should be fixed in 774e1b1
Give it a try and let me know.

@JeroenVu

@artemp Thank you for looking at this. I built mapnik from source and regenerated the map, but apparently this isn't fixed yet.

@artemp
Owner

@JeroenVu - are you using MarkersSymbolizer or PointSymbolizer ? The fix is for MarkersSymbolizer.

Pls, post what are you feeding into Mapnik so I can investigate, thanks.

@JeroenVu

@artemp Sorry, I just noticed I said "raster marker" in my first comment. I'm indeed using PointSymbolizer.

@artemp
Owner

@JeroenVu - no worries, you should be able to achieve the same functionality using MarkersSymbolizer. We're planning to merge PointSymbolizer and MarkersSymbolizer in 2.1 . Anyways, I'll fix PointSymbolizer for now, too.

@springmeyer
Owner

looks like PointSymbolizer was done in 195b8ad. This is working good, a followup now is: #1364 and #952

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.