Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

add empty geometry tests for from_wkb() #1305

Closed
springmeyer opened this Issue · 1 comment

1 participant

@springmeyer
Owner

We need to test all combinations of empty geometries to avoid invalid memory access in the wkb parsing code. At the same time we should look at testing WKT reading as well. See also #1132

@springmeyer springmeyer was assigned
@springmeyer springmeyer referenced this issue from a commit
@springmeyer springmeyer change geometry_utils::from_wkb to return a bool that signifies if at…
… least one wkb path was parsed - refs #1333 and #1305
e36081a
@springmeyer
Owner

adequate tests now after b0cb5b0, closing.

@springmeyer springmeyer referenced this issue from a commit
@springmeyer springmeyer properly skip empty geometries - refs #1333 and #1305 an #1132
+ remove redundant ar.size() > 0 check
+ use std::auto_ptr<geometry_type> to avoid memory leaks and
  improve exception safety.
9c5dbc2
@springmeyer springmeyer referenced this issue from a commit
@springmeyer springmeyer properly skip empty geometries - refs #1333 and #1305 an #1132
+ remove redundant ar.size() > 0 check
+ use std::auto_ptr<geometry_type> to avoid memory leaks and
  improve exception safety.
3bd4a4d
@springmeyer springmeyer referenced this issue from a commit
@springmeyer springmeyer change geometry_utils::from_wkb to return a bool that signifies if at…
… least one wkb path was parsed - refs #1333 and #1305
dda82bc
@rjw57 rjw57 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@rjw57 rjw57 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
@rjw57 rjw57 referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.