You can clone with
HTTPS or Subversion.
When using LineSymbolizer to draw the outline of a polygon with Cairo, the lines in the polygon doesn't seem to be closed as expected:
Tested on PDF output, viewer is latest Adobe Reader on Windows XP.
Edit: also occures on AGG
@TobWen - thanks for reporting
The problem is that you don't close the path when LineSymbolizer is used for rectangles.
Here is a small example in Python, which demonstrates the issues:
WIDTH, HEIGHT = 100, 100
surface = cairo.PDFSurface('example.pdf', WIDTH, HEIGHT)
ctx = cairo.Context(surface)
# ctx.close_path() # turning on this creates a closed path (expected for polygons: houses etc.)
@TobWen - c7af665 should close polygons
Problem still exists in e2b6572.
The fix in c7af665 is obviously not enough. The problem reported is for LineSymbolizer in Cairo and the fix only touches BuildingSymbolizer in AGG. The Cairo code seems to correctly handle closed paths (with SEG_CLOSE). However depending on the input data the path is not necessarily closed using SEG_CLOSE but instead using SEG_LINE which results in this behavior. I think it would be reasonable to implicitly close all paths where the first and the last point are the same.
@herm: This could lead into unspected behavour. Please let the user choose to close it or check the geometry type first: if polygon, then close. Please read my ideas in #1351
@TobWen - again you've not actually provided a working testcase. Closing this issue. You can re-open in a new one if you actually have a test case that uses some geodata and uses mapnik and demonstrates the problem.
A test case for this bug would be the circle in visual test "lines-4" from harfbuzz branch.
Here is a working testcase (press "download now" on the right side, download starts immediately):