Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Cannot run testsuite without installing #1397

Closed
strk opened this Issue Aug 16, 2012 · 10 comments

Comments

Projects
None yet
3 participants
Contributor

strk commented Aug 16, 2012

It looks like you can't run the tests before installing the code. It would be useful to support that, to allow "cheaper" testing (I don't want to mess with my system in order to test the upcoming release)

Contributor

strk commented Aug 16, 2012

I'm thinking about an automatic setup for the "off-build-tree" make check run

Contributor

lightmare commented Aug 16, 2012

I use these configure options for testing:

PREFIX="`pwd`/build-dev"
PYTHON_PREFIX="$PREFIX"
CUSTOM_LDFLAGS="-Wl,-rpath=$PREFIX/lib"
Contributor

strk commented Aug 16, 2012

On Thu, Aug 16, 2012 at 11:18:43AM -0700, lightmare wrote:

I use these configure options for testing:

PREFIX="`pwd`/build-dev"
PYTHON_PREFIX="$PREFIX"
CUSTOM_LDFLAGS="-Wl,-rpath=$PREFIX/lib"

It would be better for those flags NOT to affect the compilation
or you would not be able to then install the produced version
systemwide (after testing).

May be just a metter of properly cooking up something with
LD_LIBRARY_PATH and PYTHON_PREFIX within the Makefile.

This is usually taken care of by libtool (for those not hating autotools ;)

--strk;

Owner

springmeyer commented Aug 16, 2012

totally reasonable request. I've looking into out of source builds and scons has an easy option for it, but our script usage breaks since we don't use absolute paths in the globs that are used in various places to grab cpp files. Not hard to fix, but I've never got around to it.

regarding test running, I to use @lightmare's simple solution. And when I'm lazy/impatient I just do make uninstall in one build tree and make install && make test && make uninstall in another to swap them out.

Contributor

strk commented Nov 13, 2012

The simple solution doesn't work if you want to keep a "safe" system install.
Using a custom install directory doesn't work either (#1574)

Contributor

strk commented Nov 21, 2012

PYTHONPATH=./bindings/python helps python to find the module, but the module requires a library named libmapnik.so.2.1 while scons only writes libmapnik.so, so LD_LIBRARY_PATH doesn't help, we need to add a symlink to it (to SONAME)

Contributor

strk commented Nov 21, 2012

Uhm (after doing the symlinks manually to try it)... which env variable helps here ?

***NOTICE*** - no datasource plugins have been loaded
Owner

springmeyer commented Nov 27, 2012

c39c839 adds a new make target of test-local which will bootstrap things to run the tests locally. This does not handle the symlink needed on linux, but works out of the box on os x.

Contributor

strk commented Nov 27, 2012

Good job ! But could this remain open until a fix is found also for linux ?

Contributor

strk commented Nov 27, 2012

Also, does Travis run the testsuite already ?

@strk strk pushed a commit to strk/mapnik that referenced this issue Nov 30, 2012

Sandro Santilli Add the missing library link when running the testsuite locally
Provide a "check" alias for "test-local".
REF: #1397
f525036

@strk strk pushed a commit to strk/mapnik that referenced this issue Nov 30, 2012

Sandro Santilli Add the missing library link when running the testsuite locally
Provide a "check" alias for "test-local".
REF: #1397
8a57595

@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013

@PetrDlouhy Dane Springmeyer + PetrDlouhy add a test-local target to run tests without having to install - closes 22c1b8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment