debug/info log levels should be swapped #1400

Closed
gravitystorm opened this Issue Aug 16, 2012 · 3 comments

Comments

Projects
None yet
2 participants
@gravitystorm

https://github.com/mapnik/mapnik/blob/master/src/debug.cpp#L59

In most other applications "debug" is the most detailed logging, and "info" is less informative than debug. Mapnik appears (as far as I can see) to have them inverted.

See e.g.

http://httpd.apache.org/docs/2.2/mod/core.html#loglevel
http://www.ruby-doc.org/stdlib-1.9.3/libdoc/logger/rdoc/Logger.html

@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Aug 16, 2012

Owner

@gravitystorm - I agree. I also think that we have too many options - which makes things extra confusing. Since INFO is currently unused (except in the unmaintained kismet plugin), so I think we should remove it. We can also remove FATAL since mapnik, being a library, should not itself ever exit without throwing an exception.

Owner

springmeyer commented Aug 16, 2012

@gravitystorm - I agree. I also think that we have too many options - which makes things extra confusing. Since INFO is currently unused (except in the unmaintained kismet plugin), so I think we should remove it. We can also remove FATAL since mapnik, being a library, should not itself ever exit without throwing an exception.

@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Aug 16, 2012

Owner

We can, in future, releases build granularity as people find the need for more.

Owner

springmeyer commented Aug 16, 2012

We can, in future, releases build granularity as people find the need for more.

@springmeyer

This comment has been minimized.

Show comment Hide comment

springmeyer pushed a commit that referenced this issue Nov 30, 2012

springmeyer pushed a commit that referenced this issue Nov 30, 2012

PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment