Skip to content
This repository

Line clipping returns empty (invalid?) paths #1424

Closed
springmeyer opened this Issue · 2 comments

1 participant

Dane Springmeyer
Dane Springmeyer
Owner

It appears that clipping of lines frequently results in paths whose first vertex == SEG_END.

This leads to uninitialized values in our label_positions::centroid/middle_point algorithms. While these algo's recently (as part of the vertex_converters push) return bool for success, our rendering code does not handle this: see #1423

This ticket exists to discuss whether this clipping behavior is correct.

Dane Springmeyer springmeyer referenced this issue from a commit
Dane Springmeyer springmeyer return without rendering if label placement algorithm returns false i…
…ndicating a degenerate geometry - closes #1423 and refs #1424
0eff77c
Dane Springmeyer
Owner

Note: disabled line clipping for markers in 9539ce9 to avoid the problem described in #1426, which will also avoid this issue from presenting itself for markers (at least). It seems like it might be worth a check in other places we clip lines to avoid undefined behavior and/or simply optimize cases of empty paths.

Dane Springmeyer
Owner

closing as we can track at #1699

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.