use radius-sensitive padding on rendering buffer used for image-filters #1478

Closed
springmeyer opened this Issue Sep 11, 2012 · 5 comments

Comments

Projects
None yet
2 participants
Owner

springmeyer commented Sep 11, 2012

Using anything larger than a few pixel radius for agg-stack-blur will lead to tile edge artifacts like:

screen shot 2013-06-27 at 4 12 14 pm

But if we internally render the features and blur on an inflated image (~1.5* rx) then we should be able to avoid these artifacts like:

screen shot 2013-06-27 at 5 43 39 pm

Moved from mapbox/tilemill#1662

Owner

springmeyer commented Jun 26, 2013

see also #1824

👍 Need any diagnostic help?

Owner

springmeyer commented Jun 27, 2013

just imagine the possibilities:

screen shot 2013-06-27 at 6 58 31 pm

@springmeyer springmeyer pushed a commit that referenced this issue Jun 27, 2013

Dane Springmeyer automatically inflate internal pixel array to help avoid artifacts at…
… tile edges when blurring - refs #1478
af8a2c5
Owner

springmeyer commented Jun 27, 2013

first cleaned up implementation in the blur-inflate branch: https://github.com/mapnik/mapnik/compare/blur-inflate

@springmeyer springmeyer pushed a commit that referenced this issue Jul 19, 2013

Dane Springmeyer ensure agg rendering buffer uses proper dimensions since these may be…
…come more dynamic in the near future - refs #1478
f999615

@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013

@PetrDlouhy Dane Springmeyer + PetrDlouhy ensure agg rendering buffer uses proper dimensions since these may be…
…come more dynamic in the near future - refs #1478
d033b2e

@springmeyer springmeyer pushed a commit that referenced this issue Oct 3, 2013

Dane Springmeyer add support for seamless blurring - closes #1478 0224ce3

springmeyer closed this Oct 3, 2013

@springmeyer springmeyer pushed a commit to tilemill-project/tilemill that referenced this issue Oct 3, 2013

Dane Springmeyer add windows pdf/svg fix and seamless blurring feature to changelog - … a375c17

springmeyer referenced this issue in mapbox/tilelive-s3 Oct 3, 2013

Closed

remove decode/c++ bits #6

@herm herm added a commit that referenced this issue Oct 13, 2013

@herm herm Merge commit '3864fada7202c2a37bb31d47a489c297f6c5dbf5' into hb-merge
* commit '3864fada7202c2a37bb31d47a489c297f6c5dbf5':
  pass string by const ref
  remove RENDERING_STATS compile time option - refs #1956
  scons: only compile optional cpp files that really can be built
  add webp to travis - refs #1955
  scons: ensure optional imaging libaries are build if requested when cross compiling
  scons: fix the build in the case that one of the optional imaging libraries is not found
  ensure agg rendering buffer uses proper dimensions since these may become more dynamic in the near future - refs #1478
  update changelog after #1955
  webp encoding/decoding support - refs #1955
  disable failing test of #1913 for now
0d86ff6

@herm herm added a commit that referenced this issue Oct 13, 2013

@herm herm Merge commit '0224ce3019ba813d0d88e6e648e31160179b97e4' into hb-merge
* commit '0224ce3019ba813d0d88e6e648e31160179b97e4':
  add support for seamless blurring - closes #1478
df05307
Owner

springmeyer commented Feb 27, 2014

Over time in testing this feature its become clear that the requirement to buffer the data is harsh and this feature needs to be opt-in. So, going to make it disabled by default and able to be enabled via a style level option: tracking at #2165.

@springmeyer springmeyer pushed a commit to mapnik/mapnik-reference that referenced this issue Feb 27, 2014

Dane Springmeyer add image-filters-inflate - refs mapnik/mapnik#2165 mapnik/mapnik#1478 158be36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment