Should a Style with no Symbolizers trigger querying data? #1517

Closed
springmeyer opened this Issue Oct 4, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@springmeyer
Member

springmeyer commented Oct 4, 2012

Consider a style/layer like the below. This is going to be uncommon to rare, but we should still have clear behavior here. Right now this triggers a query to the datasource, which is expensive given we don't actually need the data. Shall style.active() and rule.active() return false if there are no symbolizers in any of the rules?

<Style name="test">
  <Rule>
  </Rule>
</Style>

<Layer name="test">
    <StyleName>test</StyleName>
    <Datasource>
     ....
    </Datasource>
</Layer>
@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Mar 13, 2013

Member
Member

springmeyer commented Mar 13, 2013

@springmeyer

This comment has been minimized.

Show comment Hide comment
@springmeyer

springmeyer Mar 13, 2013

Member

duplicate of/solved by #1670 in 0d8f415#src/rule.cpp

Member

springmeyer commented Mar 13, 2013

duplicate of/solved by #1670 in 0d8f415#src/rule.cpp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment