Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

karma output: handling > 16 precision #1676

Closed
springmeyer opened this Issue Jan 3, 2013 · 1 comment

Comments

Projects
None yet
1 participant
Owner

springmeyer commented Jan 3, 2013

Currently in master (2.2-pre) we have two failing tests:

tests/cpp_tests/conversions_test.cpp(68): test 'out == "0.0001234567890123456"' failed in function 'int main(int, char **)': '0.0001234567890123' != '0.0001234567890123456'
tests/cpp_tests/conversions_test.cpp(72): test 'out == "-0.0001234567890123456"' failed in function 'int main(int, char **)': '-0.0001234567890123' != '-0.0001234567890123456'

As @strk mentions in e8b7b82 this is due to https://svn.boost.org/trac/boost/ticket/7785.

This ticket stands to document the commenting of these tests until a fix in boost is available (or a workaround is found)

@springmeyer springmeyer pushed a commit that referenced this issue Jan 3, 2013

Dane Springmeyer comment failing to_string precision test - refs #1676 0aa2c49

@springmeyer springmeyer pushed a commit that referenced this issue Jan 3, 2013

Dane Springmeyer comment failing to_string precision test - refs #1676 abaca39

@springmeyer springmeyer referenced this issue in mapnik/mapnik-support Jan 3, 2013

Closed

Tests broken on 2.1.x #5

Owner

springmeyer commented Jan 18, 2013

@strk - closing this, I think the actual value we are getting is fine given it is what std::ostringstream outputs as well.

@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013

@PetrDlouhy Dane Springmeyer + PetrDlouhy comment failing to_string precision test - refs #1676 c3b0433

@PetrDlouhy PetrDlouhy added a commit to PetrDlouhy/mapnik that referenced this issue Aug 22, 2013

@PetrDlouhy Dane Springmeyer + PetrDlouhy re-enable double conversion test and make expected value match actual…
… which is fine because this is also the behavior of std::ostringstream (tested on OS X with clang++ 3.3) - closes #1676
24cc602
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment