New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moving to consistent use of '-' (dashes) in XML properties #644
Comments
[springmeyer] I want to deal with this for the Mapnik 2 release, so we get consistent and avoid this issue in the future. |
[springmeyer] good info here: http://stackoverflow.com/questions/1478486/using-in-xml-attribute-name |
[springmeyer] added snapshot of trunk in r2575 that is pre-this change. forward compatibility with this change has landed in mapnik 0.7.2: r2579 |
[springmeyer] landed in r2582, upgrade_map_xml.py updated in r2583, and basic change noted at https://trac.mapnik.org/wiki/Mapnik2/Changes |
…, and start validating property names by printing warning if they are not valid (closes #110)
We currently have mixed use of dashes and underscores in XML property names, which makes it difficult for stylesheet authors to remember property names (or easy to misspell).
Because Mapnik2 has other breaking changes, now is the time to do this.
I propose we move fully to using '-'/dashes when property names should have a break (to fit css style). Properties in python (and other potential binding languages) will consistently continue to use underscores.
Properties already using '-':
{{{
map level
background-color
background-image
metawriters
default-output
output-empty
meta-writer
meta-output
shield symbolizer
text-opacity
line symbolizer (stroke)
stroke-width
stroke-opacity
stroke-linejoin
stroke-linecap
stroke-dashoffet
stroke-dasharray
polygon symbolizer
fill-opacity
}}}
The text was updated successfully, but these errors were encountered: