datasource exception consistency #792

Open
artemp opened this Issue Oct 11, 2011 · 2 comments

Comments

Projects
None yet
2 participants
Owner

artemp commented Oct 11, 2011

If a query is made with an attribute field that does not exist in the data:

These throw:

  • shape
  • postgis

These do not:

  • csv
  • ogr
  • sqlite

Unknowns:

  • geos
  • kismet
  • osm

N/A:

  • raster
  • gdal
  • rasterlite

Others ?

Owner

artemp commented Oct 11, 2011

[springmeyer] pushing to 2.1

@springmeyer springmeyer pushed a commit that referenced this issue Dec 5, 2011

Dane Springmeyer csv plugin: ensure that the datasource throws if invalid attributes a…
…re queried to keep consistent with other datasource - refs #792
ddeca1e

@springmeyer springmeyer pushed a commit that referenced this issue Dec 5, 2011

Dane Springmeyer tests: ensure postgis plugin throws if invalid query is made - refs #792
9be619c
Owner

springmeyer commented Dec 5, 2011

hmm, looks like sqlite itself does not throw if columns referenced in a query do not exist (IF they are double or single quoted):

https://gist.github.com/1435230

hmmmm.... http://www.sqlite.org/lang_keywords.html. Seems like this is a bug: "If a keyword in double quotes (ex: "key" or "glob") is used in a context where it cannot be resolved to an identifier but where a string literal is allowed, then the token is understood to be a string literal instead of an identifier."

@springmeyer springmeyer pushed a commit that referenced this issue Dec 5, 2011

Dane Springmeyer sqlite: ensure non-existant columns requested in query prompt error b…
…y switching quoting character to brackets - closes #984 - refs #792
17852d5

@springmeyer springmeyer pushed a commit that referenced this issue Dec 5, 2011

Dane Springmeyer tests: ensure ogr plugin throws on non-existant field names (currentl…
…y fails) - refs #792
e3e0755

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer csv plugin: ensure that the datasource throws if invalid attributes a…
…re queried to keep consistent with other datasource - refs #792
37fee4b

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer tests: ensure postgis plugin throws if invalid query is made - refs #792
0191f9c

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer tests: ensure shapefile plugin throws if invalid query is made - refs #… 9cb1c9c

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer sqlite: ensure non-existant columns requested in query prompt error b…
…y switching quoting character to brackets - closes #984 - refs #792
d525218

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer tests: test sqlite error behavior on non-existant fields - refs #984/#… 75190a7

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer tests: ensure ogr plugin throws on non-existant field names (currentl…
…y fails) - refs #792
7c0bceb

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer ogr plugin: throw if non-existant fields are queried - refs #792 70a191e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment