Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

datasource exception consistency #792

Open
artemp opened this Issue · 2 comments

2 participants

@artemp
Owner

If a query is made with an attribute field that does not exist in the data:

These throw:

  • shape
  • postgis

These do not:

  • csv
  • ogr
  • sqlite

Unknowns:

  • geos
  • kismet
  • osm

N/A:

  • raster
  • gdal
  • rasterlite

Others ?

@artemp
Owner

[springmeyer] pushing to 2.1

@springmeyer springmeyer referenced this issue from a commit
@springmeyer springmeyer csv plugin: ensure that the datasource throws if invalid attributes a…
…re queried to keep consistent with other datasource - refs #792
ddeca1e
@springmeyer
Owner

hmm, looks like sqlite itself does not throw if columns referenced in a query do not exist (IF they are double or single quoted):

https://gist.github.com/1435230

hmmmm.... http://www.sqlite.org/lang_keywords.html. Seems like this is a bug: "If a keyword in double quotes (ex: "key" or "glob") is used in a context where it cannot be resolved to an identifier but where a string literal is allowed, then the token is understood to be a string literal instead of an identifier."

@springmeyer springmeyer referenced this issue from a commit
@springmeyer springmeyer sqlite: ensure non-existant columns requested in query prompt error b…
…y switching quoting character to brackets - closes #984 - refs #792
17852d5
@kkaefer kkaefer referenced this issue from a commit in kkaefer/mapnik
@springmeyer springmeyer csv plugin: ensure that the datasource throws if invalid attributes a…
…re queried to keep consistent with other datasource - refs #792
37fee4b
@kkaefer kkaefer referenced this issue from a commit in kkaefer/mapnik
@springmeyer springmeyer sqlite: ensure non-existant columns requested in query prompt error b…
…y switching quoting character to brackets - closes #984 - refs #792
d525218
@kkaefer kkaefer referenced this issue from a commit in kkaefer/mapnik
@springmeyer springmeyer tests: ensure ogr plugin throws on non-existant field names (currentl…
…y fails) - refs #792
7c0bceb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.