GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
While working with a mostly PostGIS based style sheet I noticed that data source for layers with status off were still instantiated, resulting in SRID queries to the PostGIS DB.
Since it seems unnecessary to instantiate any data source associated with an off status, I changed map_parser::parse_layer to check layer status before instantiating the data source object
load_map.cpp line 643 now has the try/catch block wrapped with
if( lyr.isActive() )
While it can be argued that this is bad behavior on the part of the the PostgreSQL driver, it seems that other input drivers could easily perform non-trivial initialization.
If you're interested in integrating this change, please advise and I'll provide a delta.
[springmeyer] yes, a simple diff would be great, thanks for the report on this. After you post the diff we'll make sure to take a closer look at this before the 2.0.1 stable release.
done in #153