merge mapnik::value_holder (params.hpp) and mapnik::value (value.hpp)? #976

Closed
springmeyer opened this Issue Dec 2, 2011 · 2 comments

Comments

Projects
None yet
1 participant
Owner

springmeyer commented Dec 2, 2011

We have a couple boost::variant typedefs that might be able to be merged so that the code that handles their conversion could be unified a bit (mostly an issue in python bindings).

Owner

springmeyer commented Dec 2, 2011

main difference is that value_holder uses std::string but mapnik::value only uses UnicodeString

@springmeyer springmeyer pushed a commit that referenced this issue Dec 3, 2011

Dane Springmeyer python: refactor interface to mapnik::parameters using poor man's ind…
…exingapproach - long term todo is merge mapnik::value_holder and mapnik::value to make this cleaner - refs #976
bc002c1

@kkaefer kkaefer pushed a commit to kkaefer/mapnik that referenced this issue Feb 16, 2012

Dane Springmeyer python: refactor interface to mapnik::parameters using poor man's ind…
…exingapproach - long term todo is merge mapnik::value_holder and mapnik::value to make this cleaner - refs #976
ad41bca
Owner

springmeyer commented May 21, 2013

not actionable. more or less fixed by #1177

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment