Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Issue #1545 - override buffer-size parameter at layer level #1551

Merged
merged 0 commits into from

3 participants

@lexman

Conflicts:

src/feature_style_processor.cpp
@springmeyer
Owner

overall, looks good.

But:

1) it appears you are using tabs perhaps? (just guessing based on github view). Please use 4 space indents.

2) Small issue: I don't like passing the layer buffer to the map.get_buffered_extent function. I think it would be cleaner to simply calculate the buffered extent in feature_style_processor from the layer, if it layers buffer is set.

Also, next week I will review in more detail. I need to check with @artemp about how to maintain the previous functionality of using a layer buffer to set the clipping extent.

@amonteilhet amonteilhet merged commit 2d0bd72 into mapnik:master

1 check passed

Details default The Travis build passed
@lexman

Hello,

I've submited a new pull request with your suggestions... In a branch (so I can still make some improvements if you need, this time) !

Forget about this pull requet, the newer one is : #1566

@springmeyer
Owner

closing superseded by #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
Showing with 0 additions and 0 deletions.
Something went wrong with that request. Please try again.