Issue #1545 - override buffer-size parameter at layer level #1551

Merged
merged 0 commits into from Nov 8, 2012

Conversation

Projects
None yet
3 participants
Contributor

lexman commented Oct 31, 2012

Conflicts:

src/feature_style_processor.cpp
Owner

springmeyer commented Nov 2, 2012

overall, looks good.

But:

  1. it appears you are using tabs perhaps? (just guessing based on github view). Please use 4 space indents.

  2. Small issue: I don't like passing the layer buffer to the map.get_buffered_extent function. I think it would be cleaner to simply calculate the buffered extent in feature_style_processor from the layer, if it layers buffer is set.

Also, next week I will review in more detail. I need to check with @artemp about how to maintain the previous functionality of using a layer buffer to set the clipping extent.

@amonteilhet amonteilhet merged commit 2d0bd72 into mapnik:master Nov 8, 2012

1 check passed

default The Travis build passed
Details
Contributor

lexman commented Nov 8, 2012

Hello,

I've submited a new pull request with your suggestions... In a branch (so I can still make some improvements if you need, this time) !

Forget about this pull requet, the newer one is : #1566

Owner

springmeyer commented Nov 29, 2012

closing superseded by #1566

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment